mayankkejriwal / gnome-p3 Goto Github PK

@minhsueh Is there a reason you didn't check in 'rl_agent_background.py' as part of the 'phase3_simulator_v1' branch?

Furthermore, found this other repo wherein the step function does not match your reward description in the paper & let's the agent assign a reward to its own action which is plain wrong from a design perspective. Not to mention incentivizing skipping above other legal moves (+2 vs +1).

So, what's the deal? Did you fake your paper's results?

The existing monopoly_simulator directory is treated as a Python project, for example:

but it does not contain an __init__.py file that specifies the directory is a Python package.

In the absence of a top-level setup.py script and monopoly_simulator/__init__.py file, it is not evident how to correctly run this code either from first principles or from the README.md file. While certain work-around involving symlinks or running python -m might work, in my sandbox these turned out to be brittle and nonstandard solutions (even for research-ware!).

Specifically, the recommendation is:

1. Create __init__.py in monopoly_simulator/ making it a Python package.
2. Write a minimal setup.py script that builds the software so that it can be executed and imported like any Python package.
3. Document the steps needed to build and run the package in the README.md so that new users can reliably build the system in a standard way.

The function seems wrong, cannot check many situations

Specifically, in the following files, the hyphens should be underscores:

• monopoly-game-schema.py
• monopoly-novelty-schema.py

(venv) ~/GNOME-p3/monopoly_simulator% git rev-parse HEAD
fa0862e141bf1ddf2c30696b9330ff825c32be78
(venv) ~/GNOME-p3/monopoly_simulator% python gameplay.py
Traceback (most recent call last):
  File "gameplay.py", line 9, in <module>
    from monopoly_simulator import background_agent_v4
ImportError: cannot import name 'background_agent_v4'

The offending import is here:

Removing the offending important resolves the issue, but perhaps _v4 should be checked into git if it is the correct version.

The existing README.md file is not formatted as a Markdown, including section titles and bullet points, and thus renders as one continuous flow of text that is hard to read, i.e.,

If README.md is converted to Markdown, then the result will be much more readable:

I followed the README, and is able to run 1 simulated game w/o the GUI by running gameplay.py.
However, was wondering how do I

1. See the game play via GUI
2. Can we pit agents against human player?
3. Can I simulate 100 games (not just 1)

ps. i have py 3.8 so had issues with Kivy and had to install this way: kivy/kivy#6563

The existing repository includes several files which should not be version controlled and distributed, including:

1. .idea
2. .DS_Store
3. __pycache__

The repository should include a .gitignore file, which, in addition to the above artifacts, specifies auto-generated artifacts, including

• game-log.txt
• single_tournament