Incorrect parameter correlations about eggla HOT 4 CLOSED

------------------------------ Dr. Kimberley Burrows Senior Research Associate in Epidemiology MRC Integrative Epidemiology Unit Population Health Sciences Bristol Medical School University of Bristol Room OS1 Oakfield House, Oakfield Grove, Bristol, BS8 2BN Email: ***@***.*** http://www.bristol.ac.uk/integrative-epidemiology/ Profile-Kimberley-Burrows<https://research-information.bris.ac.uk/en/persons/kimberley-burrows(2513bf22-07b2-44e9-ad72-133c3be48c17).html> A top 3 UK university with leading employers (High Fliers 2017) A top 5 UK university for research (REF 2014) A world top 50 university (QS Ranking 2016) My pronouns are she/her From: Mickaël Canouil ***@***.***> Sent: 10 November 2022 23:49 To: mcanouil/eggla ***@***.***> Cc: Kimberley Burrows ***@***.***>; Author ***@***.***> Subject: Re: [mcanouil/eggla] Incorrect parameter correlations (Issue #88) There were two issues: 1. Instead of selecting a subset of columns (1 to 4 mostly), a subset of rows were taken -> fixed by selecting only at the end. 2. When merging the parameters tables, if a missing value existed for an individual, all parameters were omitted -> fixed by requesting to keep all in the merge and by setting "pairwise.complete.obs" method to compute correlations between parameters. To note, these issues were in egg_correlations() and run_eggla_lmm(). — Reply to this email directly, view it on GitHub<#88 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ACNZZ2PR4YUYY66B3V4KVQLWHWCXXANCNFSM6AAAAAAR5B7OZY>. You are receiving this because you authored the thread.Message ID: ***@***.******@***.***>>

------------------------------ Dr. Kimberley Burrows Senior Research Associate in Epidemiology MRC Integrative Epidemiology Unit Population Health Sciences Bristol Medical School University of Bristol Room OS1 Oakfield House, Oakfield Grove, Bristol, BS8 2BN Email: ***@***.*** http://www.bristol.ac.uk/integrative-epidemiology/ Profile-Kimberley-Burrows<https://research-information.bris.ac.uk/en/persons/kimberley-burrows(2513bf22-07b2-44e9-ad72-133c3be48c17).html> A top 3 UK university with leading employers (High Fliers 2017) A top 5 UK university for research (REF 2014) A world top 50 university (QS Ranking 2016) My pronouns are she/her From: Mickaël Canouil ***@***.***> Sent: 10 November 2022 23:55 To: mcanouil/eggla ***@***.***> Cc: Kimberley Burrows ***@***.***>; Author ***@***.***> Subject: Re: [mcanouil/eggla] Incorrect parameter correlations (Issue #88) v0.18.2 should be released thus "officially" available later tomorrow, once the the GitHub Actions will be completed. — Reply to this email directly, view it on GitHub<#88 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ACNZZ2PCJQPFDHCCN3FTV23WHWDODANCNFSM6AAAAAAR5B7OZY>. You are receiving this because you authored the thread.Message ID: ***@***.******@***.***>>