Giter VIP home page Giter VIP logo

Comments (3)

lohedges avatar lohedges commented on May 29, 2024

This is now fixed. The problem was introduced when closing issue #46, i.e. adding a molecule to a list of molecules now extends the list, rather than creating a System object. (Previously, any multi-molecule data structure was converted to a System.) I've updated _solvent.py to reflect the changes.

I'll also have to update the binding_freenrg.py script used for the D3R2018 challenge as it will no longer work, i.e. the line...

system = merged + protein + waters

...will no longer create a system, but a list of molecules instead. We'll probably need to rethink this, as there is currently no way for the user to create a system from a list of molecules. (The System object is deliberately hidden from the user and is only used internally.)

from biosimspace.

ppxasjsm avatar ppxasjsm commented on May 29, 2024

Thank you!

from biosimspace.

lohedges avatar lohedges commented on May 29, 2024

No problem.

To get around the other issue I'll create a MoleculeList object that is subclassed from a regular Python list. I can then add a toSystem method that converts the MoleculeList to a system. Just noting here so I don't forget :-)

from biosimspace.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.