Support for Generators using LSP about vscode-languageserver-node HOT 6 OPEN

I think this is possible on the LSP level itself. However since VS Code itself doesn't support any streaming the feature would be disable in LSP in VS Code is used as a client (as it is with streaming already today).

from vscode-languageserver-node.

I have no knowledge of the architecture of LSP, do you have any files that I can read or links to understand how the TextEdit are being applied on vscode?

I was very confused about who consumes and applies the list of TextEdit returned to onFormattingDocument handlers.

If you think the support is simple, I can try to create a PR for that if you point to me which files are involved in this change.

from vscode-languageserver-node.

The support is simple in LSP since it already has support for streaming (see https://microsoft.github.io/language-server-protocol/specifications/lsp/3.17/specification/#partialResults)

Add something like this to VS Code is hard since its API doesn't support streaming right now. See microsoft/vscode#105870 for the corresponding issue in VS Code.

from vscode-languageserver-node.

Oh, I think now I understand, what you are saying is we basically can add support on the LSP of the language itself to PartialResults, and if the IDE supports that feature, it will use it.

In this case, vscode didn't support yet.

Until a few days ago, I knew nothing about LSP, I recently discovered that this is a protocol and it is being used by many IDEs, not only VSCode, so that's why I initially thought I could ask to vscode to add support.

Took me a few days to understand your phrase (and I hope I understand it now).

Anyway, let me know if I understand something incorrectly, I will study more about LSP and see how I can add support to partial results at https://github.com/microsoft/vscode-json-languageservice.

Feel free to close this issue, I think it will be more appropriate to open directly on vscode-json-languageservice, what do you think?

from vscode-languageserver-node.

I probably understand something wrong, I found no example of usage of PartialResults, or no one ever tried to implement/add support for it, or I'm searching wrong, any thoughts?

from vscode-languageserver-node.

There is one request kind that support partial results even in VS Code and that is the new pull diagnostics model.

from vscode-languageserver-node.