Giter VIP home page Giter VIP logo

samples's Introduction

samples's People

Contributors

ckittel avatar dependabot[bot] avatar hallihan avatar jocontr avatar magrande avatar marianogrms avatar mbender-ms avatar mbrat2005 avatar mtrilbybassett avatar neilpeterson avatar pramodvalavala-msft avatar rich-davies avatar utkarshayachit avatar v-fearam avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

samples's Issues

hub-spoke Sample Deployment Fails

Relating to this sample:
https://github.com/mspnp/samples/blob/master/solutions/azure-hub-spoke/azuredeploy.json

I've attempted to deploy it a few times, and it fails.

The error message is odd. It fails to deploy the bastion service on the error "another operation is in progress" on a dependent resource.

Redeploying it fails too because it uses a GUID() as a resource name, and attempts to create the Azure Firewall Workbook again when one already exists. Another error. Deleting the workbook and redeploying again causes another error on attempting to delete the AzureFirewallSubnet while the firewall on it already exists.

Deleting everything and deploying the whole thing again causes another Bastion service error. Same as the last time.

Perhaps someone else can try deploying this and see if it's just me.

SLA estimator not searching services

I just built the SLA calculator or estimator, it is up and running but the search bar does not seem to work, it does not show any service that you search for.

Here are the version I am currently using
npm -v
8.11.0
node -v
v16.15.1

Composite SLA of Multi-Region Deployment

Hi,

I am using the SLA Estimation tool to calculate the composite SLA for a set of services used in an user-flow.
The composite SLA for 1 region is calculated by the tool accurately
VMs in Az (99.99%) * Az Traffic Manager (99.99%) * Az DNS (100%) * App Gateway (99.95%)* AAD (99.99%) = 99.92%
According to the documentation (ref: https://docs.microsoft.com/en-us/azure/architecture/framework/resiliency/business-metrics#slas-for-multiregion-deployments) a Multi-Region deployment can be calculated using the following formula
The combined SLA for two regions = (1 − (1 − 0.9995) ^ 2) = 99.999975%
The combined SLA for four regions = (1 − (1 − 0.9995) ^ 4) = 99.999999%

using the formula to calculate the SLA for 2 region deployment, the value should be 99.999936%
The tool displays the same value as that of the Single Region Deployment unless one the following value(s) is changed
I changed the value of the Global Key to "yes" and the tool was able to calculate the SLA accordingly.
getResetTiers() {
return [
{ name: 'Global', pairedRegion: 'no' },
{ name: 'Web', pairedRegion: 'no' },
{ name: 'Api', pairedRegion: 'no' },
{ name: 'Data', pairedRegion: 'no' },
{ name: 'Security', pairedRegion: 'no' },
{ name: 'Network', pairedRegion: 'no' },

    ]
}

The paired regions are used by default for Storage RA-GRS tiers, that is by design. In the same way, the suggestion is to use a paired region wherever possible. However, my understanding is that irrespective of the secondary region being a paired region the SLO/SLA should increase because of the global fail-over possibilities.

Also, if there is a reason that this array dictates the calculation of the Multi-Region Composite SLA, it would be really helpful if the documentation is updated accordingly. Also, what should the end user change in the UI to get the calculation right.

The calculation code is in the MainPanel.js file, in the CalculateSLAMultiRegion function
if(tier != undefined)
regionOption = tier.pairedRegion;

        const sla = services[i].service.sla/100;
        const value = **regionOption === 'yes' ? 1-((1-sla) * (1-sla)) : sla;**

        total = total * value;

Incorrect SLA value for Azure Active Directory

Hi,

The SLA Data JSON file carries an old value (may be), for the AAD service
Reference:

"CategoryName": "Identity AD",
"Services": [ {
"CategoryName": "Identity AD",
"Name": "Active Directory",
"Notes": "Azure AD Basic or Premium required for SLA",
"ImageFile": "activedirectory.png",
"SLA": 99.900,
"SlaAgreementUrl": "https://azure.microsoft.com/support/legal/sla/active-directory" }

The value should be 99.99%. The provided SlaAgreementUrl has the updated value.

SLAEstimator

Hello,

i use npm 7.6.0 and i try to buld SLAEstimator but it fails
I go to
/samples/Reliability/SLAEstimator/SLAEstimator/SLAEstimator/ClientApp
run npm install
npm start
then i got:
Failed to compile.

./src/components/Styles.css (./node_modules/css-loader/dist/cjs.js??ref--5-oneOf-4-1!./node_modules/postcss-loader/src??postcss!./src/components/Styles.css)
Error: Can't resolve '/images/downarrow.png' in '/home/damian/samples/Reliability/SLAEstimator/SLAEstimator/SLAEstimator/ClientApp/src/components'

What can i do ?

Best regards
Damian

Deprecated and outdated parameters in Hub&Spoke sample

Dear MS PNP folks,

first of all, a "thanks" for the samples.

There are a few issues with the hub&spoke sample under "https://github.com/mspnp/samples/blob/master/solutions/azure-hub-spoke/bicep/main.bicep":

And on top of this, I believe these changes would make sense, when already updating the above values:

  • upgrade of os version Windows Server 2016 to Windows Server 2019
  • upgrade of Ubuntu 16.04 to 18.04 or 20.04

If you are interested, I would fork, make the changes, and open a pull request, if you like!

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.