Comments (5)
You probably saw that I ran into this to over at python-versioneer/python-versioneer#121 .
What change are you suggesting in clean_code
, specifically? Maybe submit a PR that works for you, so I can see what you mean?
from multibuild.
Yes I saw that, and my assumption was that you stopped short of getting at the root cause.
I struggle to write sensible shell code, more so given that travis mac osx images seem to have old versions which complicates the matter. So I first try to describe the change
Assuming this is the contents of the .git
file in the submodule root
gitdir: ../.git/modules/scikit-misc
Then it should be replaced with
gitdir: /absolute/path/to/.git/modules/scikit-misc
That should be the last action in clean_code
.
from multibuild.
Maybe this would do, assuming osx(bash version < 4) does not chock on the realpath
function
contents=`cat "$repo_dir/.git"`
relative_path=${contents:8}
absolute_path=`realpath $relative_path`
new_contents="${contents:0:8}$absolute_path"
echo new_contents > "$repo_dir/.git"
from multibuild.
Also worth noting is that the current alternative i.e using build_bdist_wheel
is not stable in the case of building a dualarch wheel for osx. Specifically, if Scipy switched to Versioneer and decided to replace build_pip_wheel
with build_bdist_wheel
in the config.sh file, then the arch
that is built second [1] would be created in a contaminated environment. Plus, in this case I am not sure if the partial test would even catch the bad build.
[1] Currently, that is x86_64
.
from multibuild.
Fixed in PR #18.
from multibuild.
Related Issues (20)
- How to select pypy3? HOT 8
- Build wheels for Python 3.10 RC1? HOT 3
- Testing manylinux_2_24 HOT 6
- Move to github actions for windows, mac, linux (x86, x86_64) HOT 5
- Port CI to Github Actions HOT 7
- get_modern_cmake - version 3?
- Cent OS 5 repos gone, manylinux1 builds fail
- Trouble building 3.10 wheels on OSX HOT 8
- Building thin arm64 wheels for MacOS 12+ HOT 5
- PLAT=x86_64 generates universal wheel for OSX & Python 3.10
- No supported wheels found for macOS arm64 HOT 1
- Recent git update has broken builds using docker images HOT 16
- Undefined symbol error with manylinux_2_28 wheel on Ubuntu 20.04 HOT 2
- LAPACK library is not found for macos builds HOT 5
- xenial_arm64v8:latest image is missing Py3.11 binary HOT 3
- Running safety prints a scary warning HOT 7
- platform = arm64 or universal2 both create x86_64 wheels HOT 1
- Use alpine 3.18 images by default for test
- python 3.11 and 3.12 builds failing on macosx and linux
- ./common_utils.sh: line 83: python: command not found HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from multibuild.