Giter VIP home page Giter VIP logo

Comments (5)

matthew-brett avatar matthew-brett commented on June 17, 2024

You probably saw that I ran into this to over at python-versioneer/python-versioneer#121 .

What change are you suggesting in clean_code, specifically? Maybe submit a PR that works for you, so I can see what you mean?

from multibuild.

has2k1 avatar has2k1 commented on June 17, 2024

Yes I saw that, and my assumption was that you stopped short of getting at the root cause.

I struggle to write sensible shell code, more so given that travis mac osx images seem to have old versions which complicates the matter. So I first try to describe the change

Assuming this is the contents of the .git file in the submodule root

gitdir: ../.git/modules/scikit-misc

Then it should be replaced with

gitdir: /absolute/path/to/.git/modules/scikit-misc

That should be the last action in clean_code.

from multibuild.

has2k1 avatar has2k1 commented on June 17, 2024

Maybe this would do, assuming osx(bash version < 4) does not chock on the realpath function

contents=`cat "$repo_dir/.git"`
relative_path=${contents:8}
absolute_path=`realpath $relative_path`
new_contents="${contents:0:8}$absolute_path"
echo new_contents > "$repo_dir/.git"

from multibuild.

has2k1 avatar has2k1 commented on June 17, 2024

Also worth noting is that the current alternative i.e using build_bdist_wheel is not stable in the case of building a dualarch wheel for osx. Specifically, if Scipy switched to Versioneer and decided to replace build_pip_wheel with build_bdist_wheel in the config.sh file, then the arch that is built second [1] would be created in a contaminated environment. Plus, in this case I am not sure if the partial test would even catch the bad build.

[1] Currently, that is x86_64.

from multibuild.

has2k1 avatar has2k1 commented on June 17, 2024

Fixed in PR #18.

from multibuild.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.