nebiolabs / plate-map Goto Github PK

it will need to be transpiled which complicates ebase's asset pipeline with a bunch of immature tools.

warning about requiring 100% completion does not clear the save button - can't try again.
it's not clear which fields are required

The gem-plate-map branch is being actively developed, however all changes are applicable to master. The problem is that the two branches have different hierarchies.

We need to decide if both branches should be maintained, or only the gem version. Alternatively, we could have a separate project for the gem version, but then things will need to be updated twice.

Allow user to select Product per well, then only display appropriate Lots

When trying to install by running npm install plate-map --save with node version 12.18.3 and npm version 6.14.7, I get the following:

http fetch GET 200 https://registry.npmjs.org/plate-map 14ms (from cache)
silly fetchPackageMetaData error for plate-map@latest No valid versions available for plate-map

same after cleaning the cache:
http fetch GET 200 https://registry.npmjs.org/plate-map 170ms

Make the group look more like a button
Clinic on the group number and select the wells

Example:
bottom-table.js:25-27 :

let singleField = this._createElement("<th></th>")
  .text("Group");
row.prepend(singleField);

When multiple JavaScript files get loaded in (example: CoreSubmission is rendering other forms within itself), this line gets repeated and the field as prepended multiple times. Instead, we want to replace the field. Use html instead of prepend

Ref: https://stackoverflow.com/questions/26268382/rails-4-ajax-rendering-partial-multiple-times-on-same-page-each-time-submit-is-h

As discussed in nebiolabs/ebase#78.

Instead of specifying options in a select or multiselect field, we need to provide a method for how to search that field's options. This should be based around Select2's loading of remote data as specified in https://select2.github.io/examples.html#data-ajax.

Once implemented this will need to be handled in ebase.

In the readme you mention this project

is designed to be easily utilized in the context of a larger scientific software application

Composing third-party code libraries in large (in fact, any) application usually comes with some sort of dependency (package) manager.

Any plans on releasing to npm maybe ?

this is needed to allow use of the plate map tool as a well selector

The current implementation makes extensive use of elements with fixed heights and widths, float tags, and other css positioning behaviors that are not adequately responsive to the size of the user interface. This should be cleaned up.

In particular the following specific items must be addressed:

• If more than 5 or 6 fields are on a tab, scroll bars are automatically triggered. The vertical scrollbar may be unavoidable, but the horizontal scrollbar is also triggered because there is insufficient space for vertical scrollbar when triggered. There are two possible solutions:
  • Make the field widths adapt to their container, and shrink when the scrollbar is triggered
  • Less preferentially, leave enough room for scrollbar to activate. The problem is scrollbar width varies.
• Allow main interface to expand to fit page, mainly for benefit of bottom table?
• Unit dropdown should be to right of input field, not on top of it.
• Use table to align fields?

Thanks in advance for this neat tool. I have been able to only get this to work with 0,0 (row, col). What I am interested in doing is on update of 0,0..to then re-draw showing 0,1 (row, col) and so on...Have not been able to figure it out without it showing the whole plate.

PATH.source does not define app, rather it defines css and js directly. npm ci; npm run start results in crash due to missing property app.

gulp.task('server.dev', async () => {
    browserSync.init({server: PATH.destination.dev.root});
    gulp.watch(PATH.source.app.css.concat(PATH.source.app.js), gulp.series('build.dev', browserSync.reload));
});

[23:02:35] TypeError: Cannot read property 'css' of undefined
    at /Users/lev1ty/Documents/031521/plate-map/gulpfile.js:167:32
    at taskWrapper (/Users/lev1ty/Documents/031521/plate-map/node_modules/undertaker/lib/set-task.js:13:15)
    at bound (domain.js:415:14)
    at runBound (domain.js:428:12)
    at asyncRunner (/Users/lev1ty/Documents/031521/plate-map/node_modules/async-done/index.js:55:18)
    at processTicksAndRejections (internal/process/task_queues.js:82:9)
[23:02:35] 'serve.dev' errored after 167 ms

This decreases the utility of amplicon selection... too many groups
e.g.

we should add the concentrations as separate check boxes from the amplicon's identity

maybe add an auto-preset button to trigger this selection

Could someone make a tutorial video how this can be used?

This tool looks pretty nice. However, I do not how to get started with it.

Thanks a lot.

having this feature would allow the use of the plate map tool as a well selection tool and trigger other javascript actions (e.g. a trace visualization)

This is to support a scenario were we have data associated with a plate, metadata could be updated but we don't want to add or delete wells anymore.

When you select multiple wells with different conditions and copy/paste them, it either pastes the same conditions for every well, or leaves fields that vary blank (I've seen both behaviors).

I don't think a user would expect this, so unless this is changed, I think there should be a warning message when you try to do this saying something like "Warning: Attempting to copy multiple wells will only copy one set of conditions."

Victor needs to be able to edit the plate-map code.

Preferably we should resolve #20, #17, and #16 first.

I am wondering how hard it is to make this work for 384-well plate maps. I adopted the code for a 96-well plate maps project and it worked very well. We might need to work with 384-well plate maps in the future so I am wondering about this...

Thanks to everyone for this wonderful code repo!

As of Select2 v4.0.6rc1 (and previous v4 versions) there is odd behavior around clicking the "unselect" x button. Instead of just removing the item in a multiselect, or clearing the selection of a select, it also opens the dropdown. This behavior was not present in 3.5.3, and has been documented since 2015 (select2/select2#3320). Despite being raised many times along with some pull requests, it has not been addressed and given the rate of work on select2 may not be for some time. While annoying, it is not a dealbreaker and hopefully will be addressed at some point. Currently the code has a workaround.

Select2 v3.5 hasn't been updated in 4 years and does not support modern javascript usage via import.