nestjsplus / test-auth-chapter-sample Goto Github PK

The profile pages serve a (unique) cat image for each logged in user. Just to give the page a little flavor. Right now I'm pulling from an open source image hoster, but I've seen it be a bit flakey. It might be worth just hosting these in Github. Any thoughts? Any spare cats pics? 🐱 😄

1. Is the chapter too long? Should we split it in two?

2. I included filenames as a comment at the top of each line. You'll also note it's TS only. These are actually related: in order to use the @@filename directive, which is used throughout the docs, you have to provide both TS and JS versions. I think, given that we want to make it really easy to both build this, and to follow a good project structure, that including filenames is important. But it does deviate a bit from other chapters. Opinions?

This is cobbled together from my research, comments shared on Github, Stack Overflow, etc. I think it represents Nest-ish coding standards, and I think it is properly implemented. However, it's "new" documentation code, so I'd really like some eyes on it!

As commented in the doc, in the Sessions section, this is one bit of the code I'm not 100% confident in. First, is this the right way to implement serialize/deserialize?

Second, I'm a little unclear why this even works. How is our SessionSerializer used by the nest-passport package? I'd like to at least understand it, and probably provide a bit of context in the doc.