Giter VIP home page Giter VIP logo

Comments (4)

alejandro5042 avatar alejandro5042 commented on June 17, 2024

Thanks for reporting this! You're right -- the styling is off.

Please verify that it is fixed in latest version. (You can force an update by your userscript extension manager settings or extension dropdown.)

from reviewboard-userscripts.

vijaysitaram avatar vijaysitaram commented on June 17, 2024

The group names being printed in white and a bright enough red definitely helps their readability on dark theme. But the numbers and links at the top (My Dashboard, New Review Request, ... Hide archived) are trickier in some cases:

  • Dark Theme: One of my monitors at home they look OK because it has high brightness and contrast through a variety of display angles. But on my other monitor, the purple/blue blends too closely into the background.

  • Middle Theme: The red numbers for the review quantity is difficult to read on the either monitor, but actually slightly worse on my brighter monitor. The links at top are significantly harder to read on my dimmer monitor because the purple/blue has poor contrast against the dimmer purplish background, especially when I'm off a little on vertical viewing angles (it's not quite as bad on a bright monitor).

What do you think about tweaking those links and even the red text in both cases to something more white or golden?

image

from reviewboard-userscripts.

alejandro5042 avatar alejandro5042 commented on June 17, 2024

Please update and verify that the golden text looks better for you!

from reviewboard-userscripts.

vijaysitaram avatar vijaysitaram commented on June 17, 2024

It's definitely more readable, thank you. On the original theme, zero counts were shown as a gray so they blended in to the background and only the non-zero red numbers were then prominent against the background. Is that something easy to do here as well? You can still see this in the light theme as well.

Here's the difference in the rendered HTML between a zero-count where it's gray:

<li class="item has-url has-count new-subsection" onclick="javascript:window.location=&quot;/dashboard/?group=GROUPNAME&amp;view=to-group&quot;; return false;">
 <div class="page-sidebar-row">
  <div class="rb-icon "></div>
  <span class="label"><a href="/dashboard/?group=GROUPNAME&amp;view=to-group">GROUPNAME</a></span>

  <span class="count count-zero">0</span>

 </div>
</li>

vs. a non-zero acount ("active") where it uses red text in the light theme:

<li class="item has-url active has-count" onclick="javascript:window.location=&quot;/dashboard/?group=GROUPNAME2&amp;view=to-group&quot;; return false;">
 <div class="page-sidebar-row">
  <div class="rb-icon "></div>
  <span class="label"><a href="/dashboard/?group=GROUPNAME2&amp;view=to-group">GROUPNAME2</a></span>

  <span class="count ">4</span>

 </div>
</li>

from reviewboard-userscripts.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.