Comments (4)
Thanks for reporting this! You're right -- the styling is off.
Please verify that it is fixed in latest version. (You can force an update by your userscript extension manager settings or extension dropdown.)
from reviewboard-userscripts.
The group names being printed in white and a bright enough red definitely helps their readability on dark theme. But the numbers and links at the top (My Dashboard, New Review Request, ... Hide archived) are trickier in some cases:
-
Dark Theme: One of my monitors at home they look OK because it has high brightness and contrast through a variety of display angles. But on my other monitor, the purple/blue blends too closely into the background.
-
Middle Theme: The red numbers for the review quantity is difficult to read on the either monitor, but actually slightly worse on my brighter monitor. The links at top are significantly harder to read on my dimmer monitor because the purple/blue has poor contrast against the dimmer purplish background, especially when I'm off a little on vertical viewing angles (it's not quite as bad on a bright monitor).
What do you think about tweaking those links and even the red text in both cases to something more white or golden?
from reviewboard-userscripts.
Please update and verify that the golden text looks better for you!
from reviewboard-userscripts.
It's definitely more readable, thank you. On the original theme, zero counts were shown as a gray so they blended in to the background and only the non-zero red numbers were then prominent against the background. Is that something easy to do here as well? You can still see this in the light theme as well.
Here's the difference in the rendered HTML between a zero-count where it's gray:
<li class="item has-url has-count new-subsection" onclick="javascript:window.location="/dashboard/?group=GROUPNAME&view=to-group"; return false;">
<div class="page-sidebar-row">
<div class="rb-icon "></div>
<span class="label"><a href="/dashboard/?group=GROUPNAME&view=to-group">GROUPNAME</a></span>
<span class="count count-zero">0</span>
</div>
</li>
vs. a non-zero acount ("active") where it uses red text in the light theme:
<li class="item has-url active has-count" onclick="javascript:window.location="/dashboard/?group=GROUPNAME2&view=to-group"; return false;">
<div class="page-sidebar-row">
<div class="rb-icon "></div>
<span class="label"><a href="/dashboard/?group=GROUPNAME2&view=to-group">GROUPNAME2</a></span>
<span class="count ">4</span>
</div>
</li>
from reviewboard-userscripts.
Related Issues (20)
- Somehow include issue count in the person's approval
- With no incoming requests, counter can still say 1
- Diffs associated with comments on Reviews page overrun the width of the main column HOT 5
- A .niconfig reviewer gave a Ship It but it is only reflected in Reviewers, not Note to Reviewers HOT 3
- Diff scrollbars and word wrap
- For screenshots, horizontal scrollbar only visible at bottom of the image HOT 2
- See if requests have issues directly from the dashboard
- Button to "ping" reviewers HOT 1
- Links for all comments
- Odd repetition of date with new display HOT 1
- Review in inbox even after user removed HOT 1
- Ability to sort based on ownership HOT 1
- Re-organization of my dashboard is applied to Outgoing reviews HOT 1
- Link formatting with inline code is broken
- Edit pencil is missing for main description
- Use the NI JS styleguide
- Empty outgoing review list tallies 1 for Incomplete HOT 1
- Change draft review header color to yellow/orange HOT 3
- Long review comments give overly wide summary boxes when you click OK HOT 1
- Review information sidebar needs to be reorganized HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from reviewboard-userscripts.