Can't stub out host when requesting multiple urls for that host about nock HOT 6 CLOSED

@theycallmeswift sorry, only now realized your ticket has been sitting here all along, you should have pointed me out to it earlier :)

The problem is that, when you mock, you start by mocking the whole hostname, and since now nock is responsible for resolving all HTTP requests to that hostname, so it's natural that it should complaint when a path is not resolved.

Or am I looking at it in the wrong way? Do you have any suggestions? Should we make this an option?

from nock.

@pgte, sorry for the delay, I've been super busy recently.

I think in the case of localhost especially, it's nice to be able to stub out only one URI at a time. This ensures that tests are truly isolated and that you're only really testing the behavior of one endpoint.

In our case, we're using Cucumber to test that a Spine application behaves properly given different API responses. I need to be able to load http://localhost/ and any URIs that map to resources on the page. The base URL just serves a static html file, so I could easily stub that out, but I don't want to have to stub out the other 7 different endpoints every time I try to test a different API response for a single endpoint.

The simplest solution I can think of is to create an option to allow unmocked endpoints for specific domains. So maybe its something like this:

// Setup
nock('http://google.com').get('/users/1').reply(200, { foo: 'bar' });
nock('http://localhost', { allowUnmocked: true }).get('/users/1').reply(200, { foo: 'bar' });

// Default
http.request({ host: "www.google.com", path: '/', port: 80 }, function() {  // ... });
# => throws an error

// allowUnmocked = true
http.request({ host: "localhost", path: '/', port: 80 }, function() {  // ... });
# => succeeds

What do you think?

from nock.

@theycallmeswift I read you, agree, should be simple to implement. I'll try to work on this today or tomorrow max.

from nock.

@theycallmeswift Nock v0.9.0 is out with this feature, just as you describe it.

from nock.

Ran into a slight problem where requests to the base path would still error out. Patched it with #36 though.

Thanks for all the help. You're the man!

from nock.

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue and add a reference to this one if it’s related. Thank you!

from nock.