> 1 nock scopes, global intercept problems about nock HOT 9 CLOSED

I prefer the first option, clearly, thanks for asking :)

No dia 03/02/2012, às 21:22, Ian Young
[email protected]
escreveu:

I noticed that in my tests using nock, if one test failed to fulfill an expectation, subsequent tests that set up the same expectation would fail, because the requests were being hijacked by a lingering intercept from the previous test. I wrote a test that demonstrates:

tap.test("scopes are independent", function(t) {
 var scope1 = nock('http://www.google.com')
   .get('/')
   .reply(200, "Hello World!");
 var scope2 = nock('http://www.google.com')
   .get('/')
   .reply(200, "Hello World!");

 var req = http.request({
     host: "www.google.com"
   , path: '/'
   , port: 80
 }, function(res) {
   res.on('end', function() {
     t.ok(scope1.isDone());
     t.ok(scope2.isDone()); // fails
     t.end();
   });
 });

 req.end();
});

What's your preferred way to fix this?

• One intercepted request could fulfill expectations from multiple scopes (in other words, the above test would pass without modification).

• nock.restore() could clear out whatever is hanging around to cause this. Test would change to something like this:

  tap.test("scopes are independent", function(t) {
  var scope1 = nock(/*...*/);
  nock.restore();
  var scope2 = nock(/*...*/);
  
  var req = http.request({
   //...
  }, function(res) {
   res.on('end', function() {
     t.notOk(scope1.isDone());
     t.ok(scope2.isDone());
     t.end();
  });
  });
  req.end();
  });

• Similar to the previous option, but give the duty to a new method rather than restore.

---

Reply to this email directly or view it on GitHub:
#30

from nock.

Sorry, backtracking here.

There is no way to make the scopes independent, since the app will be making direct calls to the HTTP module, not referencing a scope.
The interceptors are created globally, which means that what you are experiencing is the correct behavior.
There is no way to tell which scope will be caught first, depends on which request fires first.

When using nock I don't do my tests in parallel, which makes debugging stuff like this much easier.

I added some tests for this, which I think is correct behavior:

f8b7366

from nock.

Is this current behavior the desired behavior or just the expected behavior? I haven't looked closely at the interceptor internals yet, but I imagine we could change it to what I described in the first option - just need to key by a reference to scope object or something.

from nock.

So right now we're still left with cascading failures from one unsatisfied mock. If nothing else, I'd like to go for the second option, but I'm hoping to get your opinion on the above first.

from nock.

Thinking again about this, a nice feature would be to globally clean up all mocks, thinking of

nock.cleanAll();

I'll be working on this.

Sorry for the delay :)

from nock.

nock v0.10.1 now supports:

nock.cleanAll() that wipes the mocks that are setup.

please reopen this if it doesn't work for you.

Thanks!

from nock.

Perfect! Added this to my test setup and it works great.

from nock.

this crushed my productivity today. #253

from nock.

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue and add a reference to this one if it’s related. Thank you!

from nock.