Giter VIP home page Giter VIP logo

Comments (7)

timsavery avatar timsavery commented on July 21, 2024

I ran across this issue with @dscape while debugging a test that never seemed to get picked up by nock, even when pasting in the recorded code. After simply removing the port from the recorded code, everything worked as expected. I will try and get a patch together for port support if this is something you would like to support in this module.

from nock.

timsavery avatar timsavery commented on July 21, 2024

After debugging, I am pretty sure that this is only an issue when the request is generated from the "request" node module, when passing the URI as a string. This interaction seems to be broken somehow. Still looking, but not likely a problem with nock.

from nock.

iangreenleaf avatar iangreenleaf commented on July 21, 2024

Word. I tried to fix this issue on request/request#135, but it ended up being reverted because the changes were node 0.6 only.

from nock.

tiagocpontesp avatar tiagocpontesp commented on July 21, 2024

There might be a regression here!

from nock.

pgte avatar pgte commented on July 21, 2024

All tests pass, can you provide a failing test?

from nock.

tiagocpontesp avatar tiagocpontesp commented on July 21, 2024

Actually it seems like there's an issue with the recorder feature:
https://gist.github.com/tiagocpontesp/9814954

from nock.

lock avatar lock commented on July 21, 2024

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue and add a reference to this one if it’s related. Thank you!

from nock.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    πŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. πŸ“ŠπŸ“ˆπŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❀️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.