Wrong body comparison for JSON about nock HOT 10 CLOSED

The exact problem is here:

if (typeof spec == 'string') {
return body.toString() === spec;
}

doing a toString on a JSON object (obtained in json = JSON.parse(body);), returns [object] which is not the same as a string with json in it.

from nock.

Landed in v0.17.1

from nock.

Not yet :(

Assume both input parameters are strings containing json.

This line will assign json to body:
if (json !== undefined) body = json;

There's no equivalent to the spec.

This line fails:
deepEqual(spec, body);

Because one is, a string:
{"intervalPeriod":2,"intervalUnit":"hour","startTime":"2013-04-02T18:46:54.897Z","status":"enabled"}

and the other is, an object:
{ intervalPeriod: 2,
intervalUnit: 'hour',
startTime: '2013-04-02T18:46:54.897Z',
status: 'enabled' }

from nock.

I think this logic should only happen if: if (
(typeof spec == 'object') &&

Then you know you need to try to convert the body to an object from a string.

from nock.

OK, gonna make a test for this.

from nock.

if (typeof spec == 'object') {

var json;
try { json = JSON.parse(body);} catch(err) {}

etc ...
}

from nock.

LMK if you need help, i may try to work on a PR for it later today

from nock.

Landed in v0.17.2.

from nock.

Seems to be fixed now. I'm now seeing a different issue but need to investigate the root cause before. Might be something on my side. Thanks!

from nock.

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue and add a reference to this one if it’s related. Thank you!

from nock.