Comments (70)
Okay, so from what I’ve gathered by talking to a few people here, the expectations for Code & Learn are a bit diverse, as are the skill levels of attending people. I’ve gathered a few changes that people might up to do, maybe that’s enough (I’ll definitely gather a bit more), but I’m pretty sure that even if not we’re going to be able to provide attendees with things they’re interested in (@saghul even offered to help people with first libuv contributions if they’re interested in that!).
A few things that I think are okay:
- lib/internal/bootstrap_node.js
TheNativeModule._cache
can safely be turned into aMap
!var
->const
substitutions
- lib/v8.js, src/node_v8.cc:
- There are a few fields missing on
HeapStatistics
which have been added in more recent V8 versions:malloced_memory
peak_malloced_memory
does_zap_garbage
- There are a few fields missing on
- lib/util.js:
- i): The SIMD setup can be turned into a loop and the typeof checks can be removed
- ii): Support for
SharedArrayBuffer
can be added here, too. - iii): (Maybe) The catch-all
try
check intryStringify()
for circular objects is probably too unspecific
- src/udp_wrap.cc, src/stream_base.cc:
- The
uv_buf_t bufs_[16]
lines could beMaybeStackBuffer
s;
- The
- lib/internal/process.js
- (Maybe) We might want to emit a warning for signals that users shouldn’t listen on (as listed in the docs warning in nodejs/node#8410)?
- lib/internal/lazy_transform.js
- The default encoding here should be configurable and default to
crypto.DEFAULT_ENCODING
, notlatin1
?. This seems to kind of have been forgotten in nodejs/node#5522 – It would be asemver-major
change, but I think this is not going to be contentious.
- The default encoding here should be configurable and default to
- edit: nodejs/node#3208
And a few test files that could be cleaned up in NodeTodo/@Trott style:
test-c-ares.js:- A lot of
var
s that can beconst
assert.strictEqual
should be used instead ofassert.equal
- Wrap all callbacks that should be called once in
common.mustCall()
- A lot of
- test-child-process-buffering.js:
- A lot of
var
s that can beconst
assert.strictEqual
should be used instead ofassert.equal
- A lot of
- test-child-process-detached.js
- A lot of
var
s that can beconst
assert.notStrictEqual
should be used instead ofassert(… !== …)
- A lot of
- test-child-process-stdio.js:
- A lot of
var
s that can beconst
assert.strictEqual
should be used instead ofassert.equal
, the same goes fornotEqual
- A lot of
- test-child-process-stdout-flush.js:
- A lot of
var
s that can beconst
assert.strictEqual
should be used instead ofassert.equal
, the same goes fornotEqual
- Wrap all callbacks that should be called once in
common.mustCall()
- A lot of
Tomorrow we might get a better picure of how many people would be able and willing to attend (maybe @mikeal could ask a quick question when he mentions Code & Learn during the final notes)?
And @mikeal … not sure whether it makes a difference, but maybe we could add your “It's a workshop for people who want to learn how to contribute to Node.js core.” at the beginning and drop the whole “Concerns have also … need to be distributed geographically” part? I think that should clear up everything sufficiently.
/cc a couple of people who are here: @mhdawson @jasnell @bnoordhuis @saghul @mcollina @mikeal @thealphanerd
from code-and-learn.
@mikeal would this be running during the collaborator summit? Do we have resources to offer individuals, potentially with a focus on under represented groups, continued support after a code and learn?
I think it might be particularly interesting to pair current collaborators with new collaborators. It might also be great if we can offer some sort of scholarship to individuals in need so that they can focus a continued effort on getting involved.
from code-and-learn.
ping me when ya’ll are ready, I should be around
On Sep 8, 2016, at 1:12 PM, Anna Henningsen [email protected] wrote:
oh, have fun! and yeah, works for me :)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub #56 (comment), or mute the thread https://github.com/notifications/unsubscribe-auth/AAecV7QpUzKw2TFFAtUhK-7ojlm2T4I6ks5qoEHogaJpZM4IKMKM.
from code-and-learn.
For other beginners like me, who want to run single tests try running in console
/usr/bin/python tools/test.py --mode=release -J \ {path to test}
for example:
/usr/bin/python tools/test.py --mode=release -J \ parallel/test-async-wrap-disabled-propagate-parent
from code-and-learn.
@bengl I don’t think so, so: #59
from code-and-learn.
@Trott you made a slight typo in Amsterdam ;)
from code-and-learn.
I'd be up for helping with this, obviously dependent on me attending the events
from code-and-learn.
Amsterdam is my home turf (after a fashion) so I'll volunteer. I request remuneration only for the train ticket but I do tend to travel 1st class exclusively so there's that.
from code-and-learn.
happy to chip in
from code-and-learn.
We really need someone to step up to lead this effort at Amsterdam and Austin (doesn't need to be the same person each time).
from code-and-learn.
I can help as a mentor on site. Going to be fairly busy I think so I don't want to overcommit as 'lead'
from code-and-learn.
Which day is this at in Amsterdam?
I may be able to help but I definitely don't want to lead it.
from code-and-learn.
I can lead but it depends on what day it is. (EDIT: In Amsterdam.)
from code-and-learn.
Morning of the 17th.
from code-and-learn.
I’ll definitely want to be there and can probably also invest some time into it beforehand.
from code-and-learn.
How morning is morning? 17th works for me but I need to drive up from Groningen. I can be there around 11 am.
from code-and-learn.
9:00 – 12:00 (http://events.linuxfoundation.org/events/node-interactive-europe/program/agenda)
from code-and-learn.
Thanks, that page was still blank last I checked. :-)
I don't think I'll be able to make 9 am, I'd have to leave before 6 am.
from code-and-learn.
Heya, do you need anything from the events team?
from code-and-learn.
I won't be there fwiw.
from code-and-learn.
So who is going to lead?
from code-and-learn.
If nobody else is available, I can try to, even as a newbie… I’d definitely want to talk with people who have done this before in that case
from code-and-learn.
im up for being involved, let me know what I can do to help
from code-and-learn.
IRC or email? Don't worry, the biggest thing is to have some 'good first contribution' issues stacked up, everything else flows from there (after walking people through how to build first.)
from code-and-learn.
hm, how about in IRC in an hour (I’m busy until then), maybe with @thealphanerd too?
from code-and-learn.
I will be there also and can definitely help in any way that I can but I'm more than happy for @addaleax or others to take the lead if they'd like.
from code-and-learn.
I have cheese/bacon pancakes and a Danish krimi to attend to first but I'll hop onto IRC afterwards. Make it 1.30h from now.
from code-and-learn.
oh, have fun! and yeah, works for me :)
from code-and-learn.
oh, yeah, seems I forgot to comment… I should be able to lead this :)
from code-and-learn.
Great work putting that together @addaleax! FWIW, I tagged some issues as good first contributions to libuv here: https://github.com/libuv/libuv/labels/good-first-contribution So if anyone what's to go for it, I'm happy to help as a mentor.
from code-and-learn.
wow... amazing list! To this I would add that there are a number of issues tagged as docs-requested
that could be accessible to some participants.
from code-and-learn.
I would like to pickup test cleanup of test-c-ares.js
from @addaleax proposed list
from code-and-learn.
DONE Working on test-child-process-detached.js
from the comment above
from code-and-learn.
Working on test-child-process-buffering
from @addaleax's comment
from code-and-learn.
Working on test-child-process-stdout-flush.js
from @addaleax's comment
from code-and-learn.
from code-and-learn.
Working on test-child-process-stdio.js
from code-and-learn.
@MichaelTSS yeah I raised my hand ^^ I have a PR ready but you can take it if you want
from code-and-learn.
@AdriVanHoudt keep your PR I'll do something else
from code-and-learn.
@MichaelTSS Thanks and I fear @alkiskal has took it :S
from code-and-learn.
I am working on
Support for SharedArrayBuffer can be added here
from code-and-learn.
Taking var -> const in lib/internal/bootstrap_node.js
from code-and-learn.
👋 ; I am in test-path.js
.
from code-and-learn.
working on unsafe signal warning in lib/internal/process.js
from code-and-learn.
Working on support for SharedArrayBuffer
in lib/util.js
from code-and-learn.
on test-tls-connect-any-given-socket
from code-and-learn.
Working on test-os.js
!
from code-and-learn.
I am working on test-net-server-address
from code-and-learn.
Working on test-pipe-file-to-http.js
from code-and-learn.
Working con test-crypto-random.js
from code-and-learn.
Working on test-http-agent-destroyed-socket.js
from code-and-learn.
working on lib/v8.js, src/node_v8.cc
from code-and-learn.
DONE working on test-eval.js
from code-and-learn.
working on test-assert.js
from code-and-learn.
working on test/parallel/test-cluster-disconnect-idle-worker.js
from code-and-learn.
working on test/parallel/test-async-wrap-post-did-throw.js
from code-and-learn.
working on node/test/parallel/test-cluster-disconnect-unshared-tcp.js
from code-and-learn.
working on node/test/parallel/test-cluster-disconnect-unshared-udp.js
from code-and-learn.
working on test/parallel/test-fs-read.js
from code-and-learn.
working on node/test/parallel/test-child-process-send-utf8.js
from code-and-learn.
working on test/parallel/test-async-wrap-check-providers.js
test/parallel/test-async-wrap-disabled-propagate-parent.js
from code-and-learn.
working on test/parallel/test-child-process-exec-env.js
from code-and-learn.
working on lib/internal/streams/lazy_transform.js
(referred above as lib/internal/lazy_transform.js
)
from code-and-learn.
doing more var -> const in /lib/internal/child_process.js
from code-and-learn.
done working on test-child-process-disconnect.js
from code-and-learn.
Im doing some var to const in test/parallel/test-child-process-stdin.js
from code-and-learn.
DONE Working on test-child-process-cwd.js
from code-and-learn.
Is there a thread to organize this for Austin?
from code-and-learn.
Closing because this happened and planning for the next one is over in #59. As always, feel free to re-open or comment if you feel this really shouldn't be closed.
from code-and-learn.
There is now! #60
On Thu, Oct 13, 2016, 7:02 PM Anna Henningsen [email protected]
wrote:
@bengl https://github.com/bengl I don’t think so, so: #59
#59—
You are receiving this because you were mentioned.Reply to this email directly, view it on GitHub
#56 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AB46oKRQiRiPtlaqirLpJt4PI1ndUBEKks5qzrh3gaJpZM4IKMKM
.
from code-and-learn.
Related Issues (20)
- Code & Learn Saint Petersburg 2020 HOT 2
- Next events? HOT 10
- Mentors for Code-and-Learn @ NodeConf EU (Nov 5) HOT 8
- Scope of Code + Learn for JS Interactive 2018 HOT 8
- Code + Learn Copy for the JS Interactive Website HOT 7
- Mentors for Code + Learn @ Node+JS Interactive 2018 HOT 36
- COSCon'18 (China Open Source Conf) wants to hold a Code + Learn Workshop HOT 55
- Common questions at C&L events HOT 7
- Mentors for Code + Learn @ NodeConf Colombia 2019 HOT 14
- Bangalore, November 17th HOT 16
- Example coverage task HOT 1
- Mentors for Code-and-Learn @ Seattle (Dec 18) HOT 7
- JSConf Budapest 2019 would like to hold a Code & Learn Workshop HOT 11
- Code And Learn at NodeFest 2018 HOT 4
- CFP: Code + Learn @ JSConf.Asia (Singapore) 2019-06-[14|15|16] HOT 5
- Code And Learn At Beijing April 28th HOT 7
- Code & Learn Saint Petersburg 2019 HOT 9
- Bangalore, May 25th HOT 4
- Node.js Code + Learn at COSCon'19 (China Open Source Conf) HOT 14
- Code & Learn Moscow 2019 HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from code-and-learn.