Giter VIP home page Giter VIP logo

Comments (5)

mcollina avatar mcollina commented on June 22, 2024 1

I think the fix here is to avoid the use of an AsyncIterable in fetch if the full body was specified. We can save quite a bit of overhead.

from undici.

mcollina avatar mcollina commented on June 22, 2024

This is indeed tricky. On one hand, state altering verbs should not be automatically retried, on the other hand, it's a pretty common case.

from undici.

metcoder95 avatar metcoder95 commented on June 22, 2024

It might be better to just scope this to the safe methods only GET, HEAD, and OPTIONS instead of the idempotent ones.

Tho the issue seems to root the AsyncIterable that is made out of fetch.
As the AsyncIterable has been already consumed at its first request, when the RetryHandler attempts a new request, the content-length mismatch surfaces as undici fails to iterate over the body because it was already consumed.

Not sure what will be the course of action here, I'd say that maybe the handler can make a best attempt to detect specific bodies (Stream, AsyncIterable) and clone them and attempt to free them after successful request. Just will add the overhead of duplicated bodies

from undici.

metcoder95 avatar metcoder95 commented on June 22, 2024

FWIW I tested directly with Streams and are handled properly by the RetryHandler, but facing similar issue to as per fetch with AsyncIterator (once consumed it does not loop). So this is definitely something that the handler might need to be aware of

from undici.

ronag avatar ronag commented on June 22, 2024

Streams should not be possible to handle correctly unless they were 0 length.

from undici.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.