Giter VIP home page Giter VIP logo

Comments (8)

ronag avatar ronag commented on August 18, 2024 2

To really get it spec compliant:ish we would need force gc at some interval? Or we could run out of socket handles.

from undici.

mcollina avatar mcollina commented on August 18, 2024

I thought this was implemented in this way but I could not substantiate it with code.

from undici.

KhafraDev avatar KhafraDev commented on August 18, 2024

Without consuming the body I couldn't get node to gc the Response returned from fetch

from undici.

metcoder95 avatar metcoder95 commented on August 18, 2024

Without consuming the body I couldn't get node to gc the Response returned from fetch

And that happens due to WebStreams or also with normal Streams?

from undici.

mcollina avatar mcollina commented on August 18, 2024

Without consuming the body I couldn't get node to gc the Response returned from fetch

I think you got it backwards. We need to use a FinalizationRegistry to detect when Response is gc'd to consume the body. I think

let responseObject = null
keeps a strong reference of both Request and Response of a given fetch. I think some WeakRef could allow it to be collected, and therefore GC'd.

from undici.

KhafraDev avatar KhafraDev commented on August 18, 2024

no luck with that either, there are quite a few things that also have strong references to them (requestObject, controller, etc.). It'd be pretty messy dealing with all of them.

diff
diff --git a/lib/web/fetch/index.js b/lib/web/fetch/index.js
index e7115b2e..84a7a2cb 100644
--- a/lib/web/fetch/index.js
+++ b/lib/web/fetch/index.js
@@ -64,12 +64,18 @@ const { dataURLProcessor, serializeAMimeType, minimizeSupportedMimeType } = requ
 const { getGlobalDispatcher } = require('../../global')
 const { webidl } = require('./webidl')
 const { STATUS_CODES } = require('node:http')
+const { FinalizationRegistry } = require('./dispatcher-weakref')()
+
 const GET_OR_HEAD = ['GET', 'HEAD']

 const defaultUserAgent = typeof __UNDICI_IS_NODE__ !== 'undefined' || typeof esbuildDetection !== 'undefined'
   ? 'node'
   : 'undici'

+const registry = new FinalizationRegistry((response) => {
+  console.log(response)
+})
+
 /** @type {import('buffer').resolveObjectURL} */
 let resolveObjectURL

@@ -188,7 +194,10 @@ function fetch (input, init = undefined) {

       // 4. Abort the fetch() call with p, request, responseObject,
       //    and requestObject’s signal’s abort reason.
-      abortFetch(p, request, responseObject, requestObject.signal.reason)
+      const _responseObject = responseObject.deref()
+      if (_responseObject) {
+        abortFetch(p, request, responseObject, requestObject.signal.reason)
+      }
     }
   )

@@ -215,8 +224,12 @@ function fetch (input, init = undefined) {

       // 2. Abort the fetch() call with p, request, responseObject, and
       //    deserializedError.
+      const _responseObject = responseObject.deref()
+
+      if (_responseObject) {
+        abortFetch(p, request, _responseObject, controller.serializedAbortReason)
+      }

-      abortFetch(p, request, responseObject, controller.serializedAbortReason)
       return
     }

@@ -229,7 +242,8 @@ function fetch (input, init = undefined) {

     // 4. Set responseObject to the result of creating a Response object,
     // given response, "immutable", and relevantRealm.
-    responseObject = fromInnerResponse(response, 'immutable', relevantRealm)
+    responseObject = new WeakRef(fromInnerResponse(response, 'immutable', relevantRealm))
+    registry.register(responseObject, response)

     // 5. Resolve p with responseObject.
     p.resolve(responseObject)

from undici.

mcollina avatar mcollina commented on August 18, 2024

I'll take a look as well. How do you test it?

from undici.

KhafraDev avatar KhafraDev commented on August 18, 2024
const { fetch } = require('./index.js')

async function run () {
  await fetch('https://example.com')
}

run()

// otherwise process will end
setTimeout(() => {}, 120000)

from undici.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.