I installed this and seems to work well but I am surprised that there is no built in help accessible from within vim. All respectable vim plugins should provide this.

When I try to go to the error(inconsistency with pep-8) in my code after running vim-flake8, by pressing enter.
E21: Cannot make changes, 'modifiable' is off
How do I resolve this?

Hello,
I am trying to show the error at the current line using the lightbar plugin, as described in the lightbar documentation. The error is echoed, but I receive the error in the subject.
My little understanding of vim plug-ins suggests that the ShowErrorMessage() function tests the showing_variable before it is set.

    let l:cursorPos = getpos(".")
    if !exists('s:resultDict')
        return
    endif

    " if there is a message on the current line,
    " then echo it 
    if has_key(s:resultDict, l:cursorPos[1])
        let l:errorText = get(s:resultDict, l:cursorPos[1])
        echo strpart(l:errorText, 0, &columns-1)
        let b:showing_message = 1
    endif

    " if a message is already being shown,
    " then clear it
    if !b:showing_message == 0   <--------- Here!
        echo
        let b:showing_message = 0
    endif

If I set
let b:showing_message = 0
in my config file the error disappears.

First of all, awesome plugin -- this is fantastic.

That said, having a bit of an issue. Whenever I run this plugin by hitting the terminal window pops up and it's kind of annoying/distracting.

Here's a gif of the issue: http://recordit.co/59aP65CQxL

Has anyone else had a similar problem? What was the solution?

thank you for attention

Ok, I had this in vimrc:
set tabstop=4
set shiftwidth=4
set expandtab
set softtabstop=4
set autoindent
set smarttab

and I added the following to enable Flake8:
execute pathogen#infect()
filetype plugin indent on

The second line "filetype plugin indent on" is required to make Flake8 work. Without that line, I get this when trying to run Flake8:

E117: Unknown function: Flake8

So I have to add that filetype line in order to use Flake8 on python code.

However, when I turn that on, my tabstops no longer work and I get THIS whenever I try using the Tab key during an edit:

Error detected while processing function 34_SetVals:
line 12:
E121: Undefined variable: g:pydiction_location

So I am either doing something wrong, or there's a bug somewhere... I followed the instructions in the README file...

When I press f7, it just keeps saying something about how it can't find the flake8 executable script. I can open up the bash shell that comes with Git and use flake8.. so it's definitely in my path. But if I open a cmd shell and try to use flake8, windows won't see it. Any ideas why? I installed with pip to a fresh Python 2.7.2 install.

Feature to allow the user to quickly jump forward/backwards to the next/previous error.
(Maybe similar to Issue #57)

As the title says, I can't figure out why everything seems happy in VIM but running flake8 in a terminal makes a big difference.

Sometimes it works, but most of the time it does, really odd.

FWIW I'm using a virtualenv, and launching vim from within the virtualenv too. Not sure if that makes a difference (still fairly new to VIM).

Could you update the README.mdown to explicitly indicate whether vim needs to be built with Python scripting support?

e.g. the +python27 or +python33 variant if installing vim from MacPorts.

When I try :call flake8#Flake8UnplaceMarkers(), either manually or with the autocmd I set up for it (on <S-F7>), I get the following error:

Error detected while processing function flake8#Flake8UnplaceMarkers[1]..<SNR>79_UnplaceMarkers:
line    9:
E121: Undefined variable: s:markerdata
E116: Invalid arguments for function values(s:markerdata)
E15: Invalid expression: values(s:markerdata)

I get an error whether let g:flake8_show_in_gutter=1, let g:flake8_show_in_file=1 or both are set.

Vim 8.0 under Mint 19, with the following additional plugins:

Plug 'jlanzarotta/bufexplorer'
Plug 'tmhedberg/SimpylFold'
Plug 'vim-scripts/indentpython.vim'
Plug 'Rigellute/shades-of-purple.vim'
Plug 'Valloric/YouCompleteMe'
Plug 'vim-syntastic/syntastic'
Plug 'nvie/vim-flake8'

I am using anaconda as my default python and I do not have a ~/.config/flake8 file

Previously I used pyflakes, and in there, if I wanted a line of code to be excluded from flake8 checks, I would add # nopep8 at the end of the line. This does not seem to work in vim-flake8.

This plugin is great but it should not open up the quickfix for every save when a URL in a comment is over 80 chars. I want over 80 chars check, but not for long URLs in documentation. See http://stackoverflow.com/questions/10739843/how-should-i-format-a-long-url-in-a-python-comment-and-still-be-pep8-compliant

Hi!

To reproduce this error:

1. Open 2 python files in different horizontal splits (vim -O fileA.py fileB.py)
2. Go to the file in the left split
3. Run Flake8

The result will be a vertical split in the split of the right with no result on it.

If instead make the mistake on fileA you do it in fileB it works properly.

Thanks for the plugin! It's really useful! :)

Great plugin!

I'm wondering if there's a command I can run that quickly goes to the next line where there's a flake8 error. Right now I have to read the list of errors, spot the line number, and do :<line number>, but it would be nice if I could remap something like <leader>k to automatically jump to that line.

How could I do this?

I find the default grey-on-lightblue colour of the first listed flake8 error to be unreadable on my terminal. I can't quite figure out from the vim-flake8 docs how to change that. Can you make a suggestion and/or cover tweaking the colour scheme in the README?

I added the next option to my .vimrc:
let g:flake8_complexity_marker='' " disable McCabe complexity warnings
But running flake#Flake8() still displays complexity warnings:

Could you please advise?

I would suggest the option of inserting arguments that flake8 available as -- show-source and -- ignore

I have this in my ~/.vimrc:

let g:flake8_ignore="W802"

However, running vim-flake8 (with F7) still lists lots of undefined names:

/path/to/script.py|13| W802 undefined name 'request'

I can't see what I'm doing wrong...

Running Flake8() makes the window title persist after closing Vim.

I have the following in my .vimrc:

" Set the title of the Terminal window
autocmd BufEnter *
\ if getbufvar(winbufnr(winnr()), "&buftype") != "quickfix" |
\ set title |
\ endif
let &titleold=""

For each file I open in vim, the terminal's window title is set to the default "fname (path)". If I then close vim, the terminal's window is normally reset to the old title.

If I run Flake8() during a session and then quit vim, the terminal's window title is not reset (it stays as "fname (path)").

It doesn't seem to matter if the quickfix window is show or not (e.g. valid vs invalid), so I think it has something to do with the grep command.

Example given in README, namely:

autocmd FileType python map <buffer> <F3> :call Flake8()<CR>

for disabling automapping to <F7> doesn't work. The reason is that ftplugins are sourced before vimrc's autocmds. It makes this check:

if !hasmapto('Flake8(')
    noremap <buffer> <F7> :call Flake8()<CR>
endif

useless.

I've overcame this by defining:

let g:no_flake8_maps=1

which is already defined, but the README needs to be clarified so no one is confused.

It would be really useful to have an option or flag that would enable showing the error message associated with the line number which the cursor currently is on.
The error message can be displayed on the status bar
A similar feature is implemented in another package(andviro/flake8-vim). Attaching a screenshot below to illustrate what I mean.

and I can't jump back.How could i figure it out?

When utilizing the following command to run Flake8 on save, I get an "Unknown function: Flake8" error. The plugin still works, and >> is displayed next to the lines where there are errors but it's quite annoying.

Here is the code I'm using in my .vimrc file (suggested by the README):

autocmd BufWritePost *.py call Flake8()

I use Vundle instead of pathogen... not sure if that makes a difference. I'm on a Mac (OSX 10.6.8) using Mac Vim version 7.3. Any help would be appreciated! Thanks!

After installed vim flake8 my code breaks line automatically when I pass the 80 characters. How can I prevent that?

I've done this locally would you be interested in merging a PR for it?

It will look something like: let g:flake8_quickfix_height=5

I would like to be able to explicitly declare which flake8 config to use with the Flake8() function. I can currently do this by setting the flake8_cmd with flake8's --config option before each call, but it is not convenient.

I have this problem since a while now, and never succeeded to solve it on both my macOS at work or my Linux workstation at home.

When I run VIM-Flake8 on a Python file containing no error, the quickfix window is still open and displays a strange message: || 0

As a screenshot is worth thousands words: https://drive.google.com/open?id=1GiAGqLRWjPr4UvBGzs2y1HTlb4zled4y

Here is my configuration:

let g:flake8_show_in_gutter=1
let g:flake8_show_in_file=1
let g:flake8_show_quickfix=1
autocmd BufWritePost *.py call Flake8()

Does anyone else have the same problem? Is it a bug, or a feature? 😉

Hi! :) I'm trying to figure out how to customize the max line length, and the installation instructions are a little unclear on exactly which file to edit. I think the info I need should be at this link: https://flake8.readthedocs.org/en/latest/config.html but it "doesn't exist yet." Would be helpful to have a concrete example and/or fix that link for n00bs.

Thanks for a great tool!

Thanks for releasing vim-flake8!

I was wondering if you would be interested in integrating an highlighting option like in pyflakes.vim ? If so, how would you go about implementing it in vim-flake8? Let me know how I could help.

Steps to reproduce;
In your python file, add something like:
print(f"Eligible Agents: {eligible_agents}")

Screenshot of the error

When i open a python file with vim and enter F7, it turn that "File flake8 not found. Please install it first."

I had installed the flake8 package by " sudo pip3 install flake8" and vim-flake8 by "Plugin 'nvie/vim-flake8'".

And my system is centos 7 and vim' version is 8.0.

When i install the flake8 by "sudo yum install python-flake8", the vim-flake8 does work.

Hello!

Is it possible to make vim-flake8 work with such files?
I tried to make flake8 check netrw-temporary, but I did not succeed.
I think it not so hard to check buffer content if there is now real file path.
What do you think?

Thank you for your great plugins!

Hello,

Problem

I call Flake8 whenever I write to a Buffer:

autocmd BufWritePost *.py :call Flake8()

But it shows a list of errors which I've already configured to be ignored:

foo.py|28 col 80| E501 line too long (88 > 79 characters)
foo.py|36 col 1| E302 expected 2 blank lines, found 1

Here are the relevant lines from my vimrc:

execute pathogen#infect()
filetype plugin indent on

set statusline+=%#warningmsg#
set statusline+=%{SyntasticStatuslineFlag()}
set statusline+=%*
let g:syntastic_python_checkers = ['flake8', 'pylint']

let g:syntastic_python_pylint_args="-d C0103,C0111,R0201"
let g:syntastic_python_flake8_args='--ignore=F821,E302,E501'

Software

I'm using terminal NeoVim (NVIM 0.1.5-dev) on latest Mac OS X release (10.11.5)

Note: I have the same issue with standard OS X install of terminal Vim (7.3)

Notes

The Flake8 plugin appears to work as I can see it's being loaded as part of Syntastic:

Syntastic version: 3.7.0-157 (Vim 704, Darwin)                                                                    
Info for filetype: python                                                                                         
Global mode: active                                                                                               
Filetype python is active                                                                                         
The current file will be checked automatically                                                                    
Available checkers: flake8 pep8 pycodestyle pyflakes pylint python                                                
Currently enabled checkers: flake8 pylint

I've looked at :scriptnames and I can see the flake8 plugin is being loaded:

~/.vim/bundle/vim-flake8/ftplugin/python_flake8.vim
~/.vim/bundle/syntastic/syntax_checkers/python/flake8.vim

If I was to remove the following line from my vimrc:

let g:syntastic_python_flake8_args='--ignore=F821,E302,E501'

...then close Vim and re-open the relevant python file in Vim, I would see those errors appear in a quickfix window and that would be expected behaviour.

If I then put back that line into my vimrc, close Vim and re-open the relevant python file in Vim I'll see the errors are ignored. Again, expected behaviour.

The problem occurs only when calling Flake8 when writing to the current buffer. The errors re-appear, when they should be ignored.

Interestingly I noticed, when removing the flake8_args setting, that after opening the file and the quicklist window immediately appeared, that if I then wrote to the buffer I would get another quickfix window with the same errors. But the first quickfix window shows the command used as:

:flake8 "foo.py"

I think the problem is that when I use call Flake8 that I'm using the shell directly, maybe? This would explain why it's side-stepping my Syntastic ignore flag setting

I'm not sure if this is possible or if it will just make vim too slow but, do you think it would be doable to integrate flake8 in the same (or) similar way to what https://github.com/kevinw/pyflakes.git does?

Thanks

Hello,

Is there an option to increase the line length that pep8 checks?

Hi, I'm using vim-flake8 (default settings) with vim 7.4 installed via vim-plug.
Quickfix window is shown only once for a file, i.e. if I close it and then call flake8 again using F7 I'm getting "Flake8 check OK" even if I didn't fix any errors.
Changing anything in the file or opening it again via netrw doesn't help. Only reinvoking vim helps - the quickfix window is displayed again for the first time. I don't think this is an expected behaviour.

Flake8 is always showing errors when invoked from terminal.

Thanks for the help in advance.

I want use vim-flake8 in windows , I have install tlake8. why tips　“file flake8 not found ...” .
I need to change the config ?

I configure it in my init.vim to show errors in file instead of a quick fix window. is it possible to show these error in a popup window while hovering?

Is it possible to distinguish between errors that come from the linter (syntax errors) and PEP-8 violations? I'd like to have different colors and symbols for them.
If not possible, according to Flake8 docs there is at least one error code that is different from the others E999 that is raised when the file does not compile in a correct syntax tree, and that could be catched in a different category?
Thanks!

For some weird reason that I'm still debugging, when putting autocmd BufWritePost *.py call MaybeFlake8() flake8 runs for every single buffer on save, which takes about 4 seconds.

What's more, because flake8 is blocking, I have to wait for those 4 seconds to finish before being able to type anything.

This ticket is about making vim-flake8 asynchronous, so that we can still use vim while flake8 is running.

It seems @alfredodeza https://github.com/alfredodeza/khuno.vim implemented something similar. Any interest in doing the same?

It will feel very familiar to vim users if vim-flake8 executes with vim command like :flake8 instead of hitting <F7> key.
Or you can make both options available.
This is only my suggestion if this happens I am sure much more users will be happy.

Thanks @nvie of nice plugin.

I've got flake8 checking enabled via autocmd for reading files.

Unfortunately, this makes it so when I open a .py file, flake8 runs, opens error list window, and moves my cursor there.

It'd be nice if there was an option somewhere to prevent this.

Hello! flake8.py has --builtins command line option which isn't read from .pep8 config. The attached patch adds g:flake8_builtins configuration variable that passes --builtins to flake8.py.

Thank you for the plugin!

BTW, why it's mapped to F7? It would be logical to map it to F8, no? ;-)

diff --git a/README.mdown b/README.mdown
index 86a09cb..7a01cf8 100644
--- a/README.mdown
+++ b/README.mdown
@@ -34,6 +34,10 @@ the `<F7>` key if so.  For example, to remap it to `<F3>` instead, use:

     autocmd FileType python map <buffer> <F3> :call Flake8()<CR>

+To add builtins, in your .vimrc:
+
+    let g:flake8_builtins="_,apply"
+
 To ignore errors, in your .vimrc:

     let g:flake8_ignore="E501,W293"
diff --git a/ftplugin/python_flake8.vim b/ftplugin/python_flake8.vim
index 2fc7ed4..710abf7 100644
--- a/ftplugin/python_flake8.vim
+++ b/ftplugin/python_flake8.vim
@@ -37,6 +37,12 @@ if !exists("*Flake8()")
         endif

         " read config
+        if exists("g:flake8_builtins")
+            let s:flake8_builtins_opt=" --builtins=".g:flake8_builtins
+        else
+            let s:flake8_builtins_opt=""
+        endif
+
         if exists("g:flake8_ignore")
             let s:flake8_ignores=" --ignore=".g:flake8_ignore
         else
@@ -57,7 +63,7 @@ if !exists("*Flake8()")

         " perform the grep itself
         let &grepformat="%f:%l:%c: %m\,%f:%l: %m"
-        let &grepprg=s:flake8_cmd.s:flake8_ignores.s:flake8_max_line_length.s:flake8_max_complexity
+        let &grepprg=s:flake8_cmd.s:flake8_builtins_opt.s:flake8_ignores.s:flake8_max_line_length.s:flake8_max_complexity
         silent! grep! %

         " restore grep settings

For one of my source files, flake8 fails with

IndexError: list index out of range

vim-flake8 doesn't see the exit code and reports "OK", though.

Hi!

This page reads - https://github.com/nvie/vim-flake8

Customization

If you don't want to use the <F7> key for flake8-checking, simply remap it to another key. It autodetects whether it has been remapped and won't register the <F7> key if so. For example, to remap it to <F3> instead, use:

autocmd FileType python map <buffer> <F3> :call Flake8()<CR>

However having added this line to my .vimrc, still does the flake8 thing instead of my previous mapping which is :cp in the quickfix window:

autocmd FileType python map <buffer> <F5> :call Flake8()<CR>

please look into correcting it because vim-flake8 does not work as advertised.

Using noremap! binds the key in input mode, causing the F7 key to insert :call Flake8() in the middle of whatever you're typing, and never resulting in the command actually running. It should be replaced with cnoremap if you definitely want it to work in command-line mode (only useful if you entered command-line mode but didn't type anything yet) or removed altogether.

I try to add this

autocmd bufenter * if (winnr("$") == 1 && exists("b:loaded_flake8_ftplugin") && b:loaded_flake8_ftplugin == "primary") | q | endif

but it not work