Comments (3)
I don’t really care about hiding one dependency. Anyone with a good DI setup will have the dependencies automatically passed to the constructor anyway.
Are we (theoretically) providing better performance the way we do it now? Because we already have access to a parsed URL (in the loosest form), and if we concatenate it into a single long string the underlying Uri
/ ServerRequestFactory
will have to re-parse it again.
I think we should aim for whatever is the most performant or stable option, rather than the option that lets us cut an argument from __construct
.
from psr7-server.
I am not sure what the pros/cons are of this. The only thing I can think of is that ServerRequestCreator
gets to have 1 less factory to depend on?
from psr7-server.
Exactly. That is the benefit of it. We basically hide that dependency to the ServerRequestFactory implementation. Or, maybe not hide it because the ServerRequestFactory implementation will just do new Uri($uri)
from psr7-server.
Related Issues (17)
- Version 1.0? HOT 6
- Should fromGlobals also set the HTTP request body? HOT 1
- Failed to create UploadedFile when an upload error occurred HOT 2
- Static method in interface? HOT 2
- Duplicated port in URI HOT 3
- Incorrect scheme/port when using a proxy-server HOT 15
- Better Namespaces HOT 3
- Fix tests fixtures
- Header with only numbers seems to cause exception HOT 23
- Empty file upload gives fatal error in PHP 8.0 HOT 1
- Filter headers consisting only of whitespace before creating a ServerRequest HOT 2
- Duplicate host values in Host header when creating a Psr request from globals
- Uri::withPort + numeric strings
- Scheme detection problem
- psr/http-message version issue HOT 4
- Hope support php8.1 HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from psr7-server.