Comments (2)
Any particular reason why
getHeadersFromServer
is part ofServerRequestCreatorInterface
?
This would be a question for @Nyholm.
Although I will take responsibility (the blame?) for making it static. Mostly as it didn’t make a lot of sense (to me) to have a method that is basically a polyfill for getallheaders()
depend on a class being instantiated before calling it.
My thought process on this method was something along these lines:
- Use of this class often requires access to the request header values,
- it is impossible to rely on
getallheaders()
in many environments, - if the class needs to be useful in many environments a
getallheaders()
polyfill is required, - such a polyfill makes sense to be usable as a standalone piece of code.
That said, I do understand where you are coming from with its use in an interface.
What would be an intuitive way of requiring what is basically a polyfill? Preferably in such a way that it can easily be reused so people do not end up having multiple copies of the same polyfill in their code-base?
Of course it can be dropped from the interface completely. But I would expect implementations to often end up putting such code inside their fromGlobals()
method anyway.
from psr7-server.
Although I will take responsibility (the blame?) for making it static
I don't have a problem with the fact that it's static - it's a pure functions, so that's fine.
What would be an intuitive way of requiring what is basically a polyfill?
A pure function, such as you have :-)
Of course it can be dropped from the interface completely.
That's all I'm suggesting :-)
My only point is that static methods in interfaces are generally meaningless - you can force somebody to implement a static method, but calling it in the abstract isn't really a thing.
from psr7-server.
Related Issues (17)
- Version 1.0? HOT 6
- Should fromGlobals also set the HTTP request body? HOT 1
- Stop using UriFactory HOT 3
- Failed to create UploadedFile when an upload error occurred HOT 2
- Duplicated port in URI HOT 3
- Incorrect scheme/port when using a proxy-server HOT 15
- Better Namespaces HOT 3
- Fix tests fixtures
- Header with only numbers seems to cause exception HOT 23
- Empty file upload gives fatal error in PHP 8.0 HOT 1
- Filter headers consisting only of whitespace before creating a ServerRequest HOT 2
- Duplicate host values in Host header when creating a Psr request from globals
- Uri::withPort + numeric strings
- Scheme detection problem
- psr/http-message version issue HOT 4
- Hope support php8.1 HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from psr7-server.