Giter VIP home page Giter VIP logo

Comments (3)

stroebjo avatar stroebjo commented on June 24, 2024 1

Can you release a new Version with this fix? Had this issue in a project using your library.

from psr7-server.

Zegnat avatar Zegnat commented on June 24, 2024

Could you create a test for this to show it failing? From a quick reread of the code, we should already be handling ports as part of $_SERVER['HTTP_HOST']. Specifically, if HTTP_HOST ends in a port, we split it away from the hostname and set that port as the actual port to use:

psr7-server/src/ServerRequestCreator.php

Lines 256 to 257 in 4d03768

if (1 === \preg_match('/^(.+)\:(\d+)$/', $server['HTTP_HOST'], $matches)) {
$uri = $uri->withHost($matches[1])->withPort($matches[2]);

from psr7-server.

ondrejbouda avatar ondrejbouda commented on June 24, 2024

Great, it seems to be resolved by pull request #26 . I was using version 0.3.0 without this fix. I will use master for now.

from psr7-server.

Related Issues (17)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.