Giter VIP home page Giter VIP logo

Comments (6)

olimorris avatar olimorris commented on July 21, 2024

Just pushed a potential fix. Could you let me know if that works?

from persisted.nvim.

DeadlySquad13 avatar DeadlySquad13 commented on July 21, 2024

Just pushed a potential fix. Could you let me know if that works?

Hello! Thanks for the attention to my issue, It's now working fine!
I have only problem with dir and save_dir options with Telescope persisted specifically, I decided to post it in another issue as thought it would be more appropriate: #13 (comment)
Mentioning it here just in case.

from persisted.nvim.

olimorris avatar olimorris commented on July 21, 2024

From #13

However, it seems like Telescope persisted still takes only dir into consideration as it loads only sessions saved while dir option is set.

Steps to reproduce:

  1. Remove dir option,
  2. set save_dir instead,
  3. restart nvim to apply settings,
  4. spam some files and save session,
  5. restart vim
  6. open Telescope persisted and your newly created session won't be displayed.

from persisted.nvim.

olimorris avatar olimorris commented on July 21, 2024

@DeadlySquad13 I'm reluctant to fix this given we state in the config that users should use the save_dir config option. I allowed for dir as I changed the API and didn't want users config to break. But I don't want to add functionality to anticipate users switching between the old and new API.

from persisted.nvim.

DeadlySquad13 avatar DeadlySquad13 commented on July 21, 2024

@DeadlySquad13 I'm reluctant to fix this given we state in the config that users should use the save_dir config option. I allowed for dir as I changed the API and didn't want users config to break. But I don't want to add functionality to anticipate users switching between the old and new API.

I understand your decision. Unfortunately, the problem is that Telescope persisted in my case works only with dir but not with save_dir. I added step "remove dir option" only to make sure that only save_dir is used, I wasn't insisting that users should jump from old to new api and back.

from persisted.nvim.

olimorris avatar olimorris commented on July 21, 2024

@DeadlySquad13 - Have you pulled the latest version of the plugin?

There is nowhere in the code which references soley the dir option. For example, here, we attempt to use the dir option and if it's not present we use the save_dir one (which is technically always present as it's in the default config).

My only thought is that perhaps the session isn't saved at all. once you've carried out your "steps to reproduce", above. The Telescope extension relies on the plugin to do all of the heavy lifting like list sessions, source them etc.

from persisted.nvim.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.