Rename Stoppable to Pausable about openzeppelin-contracts HOT 6 CLOSED

Hi! I'm interested in tackling this issue, since I'm still scared of open source contributions, and this one seems pretty manageable. So, just to make sure, here's what I've done: I cloned the whole project and then replaced all instances of 'Stoppable' to 'Pausable'.

Now, How do I run tests for it?

Thanks in advance and sorry for the silly question!

from openzeppelin-contracts.

Hi @JGcarv, thanks for taking the time to contribute to OpenZeppelin.

You should be able to run the tests with npm test after installing all dependencies (npm install) and running an instance of testrpc in another console.

testrpc is installed with npm install -g ethereumjs-testrpc

from openzeppelin-contracts.

Hey @federicobond , thanks for the reply!

So, I installed the dependencies and ran the tests(which were all passing) but when I tried to git push origin myBranch I got the following message:

remote: Permission to OpenZeppelin/zeppelin-solidity.git denied to JGcarv. fatal: unable to access 'https://github.com/OpenZeppelin/zeppelin-solidity.git/': The requested URL returned error: 403

Do you have any idea what it might be? Thanks!

from openzeppelin-contracts.

Yes, you cannot push directly to the OpenZeppelin fork because you are not a collaborator. You should make your own fork on GitHub and configure your local clone to push there, like this:

git remote rename origin upstream
git remote add origin [email protected]:JGcarv/zeppelin-solidity.git

Once you do that, you will be able to push your branch:

git push -u origin myBranch

If you want to pull updates from the official fork later, you can then do so like this:

git pull upstream master

from openzeppelin-contracts.

Yeah, that makes sense.

Anyway, I followed the steps and made a new pull request. Let me know if things do work out.

Also, thank you for your patience!

from openzeppelin-contracts.

Great work @JGcarv, closing this :)

from openzeppelin-contracts.