Giter VIP home page Giter VIP logo

Comments (9)

rianrietveld avatar rianrietveld commented on August 19, 2024

+1 for "Make the anchor text include the name of the site being linked to, in a screen-reader-text span and style appropriately.'"

from simple-social-icons.

michaelbeil avatar michaelbeil commented on August 19, 2024

👍

from simple-social-icons.

rianrietveld avatar rianrietveld commented on August 19, 2024

Maybe for Genesis 2.2: when the add_theme_support( 'genesis-accessibility') is true, add the site name in a span with the class screen-reader-text?

from simple-social-icons.

nathanrice avatar nathanrice commented on August 19, 2024

SSI has its own stylesheet we can add this to, if necessary.

from simple-social-icons.

michaelbeil avatar michaelbeil commented on August 19, 2024
/* Screen Readers
------------------------------- */
.screen-reader-text,
.screen-reader-text span,
.search-form label {
    clip: rect(0, 0, 0, 0);
    height: 0;
    position: absolute;
    width: 0;
}

Like what you cued Robin on @Rrwd.

And then adding that class to the array:
'bloglovin' => '<span class="&#xe80f;"><span class="screen-reader-text">Bloglovin</span>',

That could be great @nathanrice.

from simple-social-icons.

GaryJones avatar GaryJones commented on August 19, 2024

Here's a workaround for those who need it (hint: everybody): https://gist.github.com/robincornett/d3775b24b75e443a76e5

from simple-social-icons.

nickcernis avatar nickcernis commented on August 19, 2024

@GaryJones There's an upcoming update and switch to SVG that includes screenreader text spans:

from simple-social-icons.

bgardner avatar bgardner commented on August 19, 2024

@nickcernis Do you think this can be closed now, due to 9a6e922?

from simple-social-icons.

GaryJones avatar GaryJones commented on August 19, 2024

Since this issues was raised before 2.0, this specific implementation issue is now gone. #32 replaces it with the intention of still improving accessibility.

from simple-social-icons.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.