oyvindeh / flipcss Goto Github PK

amazing stuff by the way

just thought id highlight a bug...

this "padding: 0 2em 0 3em" will flip to this "padding: 0 3em 0 2em" perfectly fine.

However...
this "padding: 0 2.5em 0 3.5em" will not flip

seems that adding a "." to the padding value stops it from working

Hi, I think I found a bug. If you run this code:

You will get flipped right/left in url adresses. But you couldn't be sure that users of this library have RTL images of every image.

I think this should be optional or unsupported feature.

The "left" and "right" keywords are always matched. This is useful when they are part of for example a filename ("arrow-left.png"). However, it is not so usefull when you have a class name containing one of them (e.g. ".copyright").

Suggestion: Check if "left"/"right" is part of a word, or separated somehow. Separators could be dots, hyphens, underscores, whitespace, etc. Swap if there is a separator, but leave if there is not.

Hi, could you please add new option to swap :before and :after pseudo elements? I'm using font-icons that are applied to element via those pseudo class and in RTL I need them to be swapped.

Used as a library, rtl/ltr-only rules can be cleaned without flipping. This is currently not possible from command line. This should be added.

Tests should be refactored to not rely on fixtures (except for the functional tests).

Reason: If a test fails, it is difficult to find out exactly what makes it break. Close inspection of the input, output and expected output is needed. By adding one test for each case to be tested, you can spot what makes it break immediately.

Hi, you've added support for swapping pseudo elements in #8 issue, but there is no way how to set this option to true because current API signature is

flip(String css, Boolean warnings)

Support for running flipcss from command line should be added.

The library should support RTL>LTR conversion, in addition to LTR>RTL.

Currently, "direction: rtl" is always added when calling flip(), breaking support for RTL>LTR. This can be fixed by adding a parameter to flip(), telling the direction and then adding direction rule to body based on that. If no direction is given, it should still flip.

As there is already an optional boolean parameter about warnings, the best solution is probably to accept an options JSON object to flip(), like so:

options = { warnings: true, direction: "ltr"}; # both warnings and direction are optional flip(options)