Deion getXSize() and <code

Must be a regression in <a class="commit-link" data-hovercard-type="commit" data-hover

<div class="highlight highlight-source-python notranslate position-relative overflow-auto" dir="auto

This was caused by the fix to <a class="issue-link js-issue-link" data-error-text="Fai

Incorrect window size returned if app is set to fullscreen about panda3d HOT 5 OPEN

MonsieurBerthier commented on May 30, 2024

Incorrect window size returned if app is set to fullscreen

from panda3d.

Comments (5)

serkkz commented on May 30, 2024

This problem is more interesting than it seems. I'm on Windows, my display resolution is 1920 by 1080, previously before Panda3D 1.10.14 this code created a full-screen window, now only 640 by 480.

from panda3d.core import GraphicsEngine, GraphicsPipeSelection, WindowProperties, \
FrameBufferProperties, GraphicsPipe

engine = GraphicsEngine.get_global_ptr()
pipe = GraphicsPipeSelection.get_global_ptr().make_default_pipe()

win_prop = WindowProperties()
win_prop.fullscreen = True
win_prop.size = (1920, 1080)
#win_prop.size = (800, 600)

win = engine.make_output(pipe,
                         name = "window",
                         sort=0,
                         fb_prop = FrameBufferProperties(),
                         win_prop = win_prop,
                         flags = GraphicsPipe.BF_require_window)
                         

while not win.is_closed():
    win.engine.render_frame()

It is worth noting that this is not observed if the size is specified differently than that of the display.

from panda3d.

rdb commented on May 30, 2024

Must be a regression in 389b24e.

Is the reported base.pipe.display_width/_height correct?

from panda3d.

serkkz commented on May 30, 2024

from panda3d.core import GraphicsEngine, GraphicsPipeSelection, WindowProperties, \
FrameBufferProperties, GraphicsPipe

engine = GraphicsEngine.get_global_ptr()
pipe = GraphicsPipeSelection.get_global_ptr().make_default_pipe()

win_prop = WindowProperties()
win_prop.fullscreen = True
win_prop.size = (1920, 1080)
#win_prop.size = (800, 600)

win = engine.make_output(pipe,
                         name = "window",
                         sort=0,
                         fb_prop = FrameBufferProperties(),
                         win_prop = win_prop,
                         flags = GraphicsPipe.BF_require_window)

print(pipe.display_width, pipe.display_height)
print(win.get_x_size(), win.get_y_size())

while not win.is_closed():
    win.engine.render_frame()