Giter VIP home page Giter VIP logo

Comments (3)

rdb avatar rdb commented on May 14, 2024

Thanks for the comprehensive test case! I've fixed this now for the cases you described.

from panda3d.

Epihaius avatar Epihaius commented on May 14, 2024

Thank you for the fixes! It is indeed working quite well now, except for one (hopefully last) remaining difference: any combine mode using CS_constant_color_scale as one of its sources still gives a different result; see e.g. example 4 I gave earlier:

stage 1: M_modulate
stage 2: CM_modulate, CS_constant_color_scale, CO_src_color, CS_previous, CO_src_color

The M_blend_color_scale mode does work correctly now, but perhaps the combine source was overlooked?
Then again, could it be that CS_constant_color_scale is not that well supported by the fixed-function pipeline, while the ShaderGenerator gives the expected results?

Apart from this, do you think it's worth investigating the alpha combine modes as well, or is it safe to assume that a correctly working rgb combine mode guarantees that the corresponding alpha combine mode works correctly also?

from panda3d.

Epihaius avatar Epihaius commented on May 14, 2024

After editing the code sample to take alpha into account, it looks like the FFP ignores alpha when setting the mode of either or both texture stages to M_blend_color_scale; the result looks identical when setting the mode to M_blend (using the FFP).

from panda3d.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.