patrickheck / socialshareprivacy Goto Github PK

In line 32 (_display:inline;) and line 107 (_line-height: 0;) of file socialshareprivacy / socialshareprivacy.css the prefixing asterisks should be removed.

Thanks. :)

A request has been made at https://www.drupal.org/node/2691543 to whitelist this repository so that it can be packaged with Drupal distributions from Drupal.org. I see from the README.md that you are using an MIT license, but what you are linking to is just a template for the LICENSE file you should be including in the repo with your project. One of the clauses of the MIT license is...

The above copyright notice and this permission notice shall be included in all copies or substantial portions of the Software.

What this means for Drupal is by allowing developers to package your code with their project without the license, we're technically violating the MIT license. Please use the MIT license template to create a LICENSE file and commit that to your repo.

I tried to used your version with the Github version as of 2.5.2013. This gives me the following error:

Please use the correct Facebook logo that can be seen on the official share or like buttons at https://developers.facebook.com/docs/plugins.

Hello Patrick,

I just want to let you know that this plugin isn't working on IIS because the lang file can not be loaded. In IIS there is no mime type set for .lang by default. So the lang file fails to load.

If one sets the mime type .lang > text/plain everything works fine.

Oh I forgot....thank you very much for this plugin.It saved me time :).

Yours
Wulle

Die Socialprivacy-Toolbar ist leider mit jQuery 1.9 inkompatibel, da die Methode "browser" entfernt wurde.

Zeitstempel: 17.04.13 17:20:14
Fehler: TypeError: $.browser is undefined
Quelldatei: .../jquery.socialshareprivacy.js
Zeile: 338

http://jquery.com/upgrade-guide/1.9/#jquery-browser-removed

The facebook like and share button has changed the design (https://developers.facebook.com/blog/post/2013/11/06/introducing-new-like-and-share-buttons/), so the dummy image needs to be adapted.
Also the google+ button changed a litte bit and the dummy image needs to be adapted too.

Cheers,

Jonathan

Thanks for making this! Maybe c't could link to your repo from http://www.heise.de/extras/socialshareprivacy/ ?

There is a new release from Heise:
http://www.heise.de/newsticker/meldung/Fuer-mehr-Datenschutz-Neue-Version-der-2-Klick-Empfehlungsbuttons-2101045.html

You might want to merge it.

It seems like they still have no open repository for it.
I have asked in a comment about it: http://www.heise.de/newsticker/foren/S-Repository-z-B-Github/forum-273985/msg-24717407/read/