peopledoc / django-generic-filters Goto Github PK

can you compare this package with more known django-filter

We should add the possiblity to add extra kwargs on form by the .get_form_kwargs() method.

PR coming, backward compatible.

The DISTINCT clause is not necessary where there is no AGGREGAT or COUNT, and must not be added on all queries. Adding a DISTINCT kill performance mostly with ORDER BY.

https://github.com/novapost/django-generic-filters/blob/master/django_genericfilters/views.py#L136

http://pythonwheels.com/

At the moment we uses form_invalid in both cases(invalid or not submitted) is
not clear.

Currently you can't use filter_fields to filter on related models. for example, you can't filter on related_model__name.

a qs_filterfields dict can be created to implement this behavior. For exemple:

{'related_model__name': 'name'}

remove the get_hidden_field method and set the widget type in the revelant mixins.

Mixins should not inherit from forms.Form but from object (otherwise it's not Mixin anymore)

FilteredListView need more documentation

Unless otherwise specified, I will setup the following milestones to manage issues in the bugtracker:

• have a X.X (example: 0.9) milestone for features we merge in master. So that we can get the list of tickets for each release.
• have a "soon" milestone, where we put tickets with either high priority or simple changes: tickets that are candidates for the next milestone. As an example features/bugs that are must-have.
• have a "later" milestone, where we put tickets with lower priority. As an example features that are nice-to-have or tickets that are too big for a near future.
• have a "maybe, one day" milestone, where we put ideas we'd like to implement, but that we do not plan to implement soon. As an example features that involve really big changes, or significant API changes... This milestone would participate to vision, a.k.a. the long term roadmap.

I use this scheme in several projects, such as:

• https://github.com/diecutter/diecutter/issues/milestones
• https://github.com/benoitbryon/django-downloadview/issues/milestones
• https://github.com/python-hospital/hospital/issues/milestones

... and I like it ;)

CHANGELOG and README also mention the "roadmap". Example: https://github.com/diecutter/diecutter/blob/9d9066a17dde6cd42cea4301ba576ed669ef7ed1/README.rst (end of file) and https://github.com/diecutter/diecutter/blob/9d9066a17dde6cd42cea4301ba576ed669ef7ed1/CHANGELOG#L197

I can publish an article on this topic on our Novapost blog, then reference this article in the CONTRIBUTING file.

cf https://github.com/novafloss/django-generic-filters/blob/master/tox.ini#L7

At the moment, we do not use the wiki feature on Github. I will remove the wiki, unless otherwise specified.

FilteredView should be able to get a standard list of filter fields via the filter_fields parameter.

One should be able to override this method to implement his own list of filters.

Hello, i was wondering if there a plans to add support for Bootstrap 5? Bootstrap 5 doesn't use jquery, so JS there might be an overhaul in the JS for this support.

Line 13 of forms.py on this page: https://pypi.python.org/pypi/django-generic-filters/0.8

is_superuser = gf.ChoiceField(label=_('Superuser')))

has an extra bracket at the end.

Re #49 ,

bunch should be replaced with an alternative, such as https://pypi.org/project/python-box/

Please see https://github.com/dsc/bunch/issues . Distros have dropped it, because it fails its own test suite on Python 3.

If queryformmixin only exists to attach a hidden text input field on the form, which was quite confusing at first, why is it setup like this?

I have to not use it in order to do any queries unless i want to un-hide the query input on the client using javascript. It just seem so contradictory. Is there some explanation why its setup like this? Otherwise I may write a pull request to clean it up.

Add documentation on forms.py

why you don't use search lookup for full-text search?
currently, just Mysql is supported (for a Postgresql implementation, django-pg-fts can be used)

We need to display checkboxes right next to their labels.