Giter VIP home page Giter VIP logo

Comments (5)

blakeembrey avatar blakeembrey commented on July 24, 2024

Thanks, I'll check it out ASAP 👍

from path-to-regexp.

blakeembrey avatar blakeembrey commented on July 24, 2024

@dougwilson Would you be willing to take a quick look at #56? I managed to take a different approach that requires no changes from Express (in fact, you can simplify the code since there's no more undefined params - kind of like 1.x).

Edit: Actually, it's still possible to have undefined params but it'll only happen on RegExp input. It could be changed to match 1.x where we just pull out the params for you.

from path-to-regexp.

dougwilson avatar dougwilson commented on July 24, 2024

Looks great!

from path-to-regexp.

blakeembrey avatar blakeembrey commented on July 24, 2024

@dougwilson Whoops, forgot to update the previous edit because I ended up fixing that issue too - undefined shouldn't ever come out for a match index anymore.

from path-to-regexp.

dougwilson avatar dougwilson commented on July 24, 2024

Whoops, forgot to update the previous edit because I ended up fixing that issue too - undefined shouldn't ever come out for a match index anymore.

haha, I figured as much from the code, so I just kinda ignored it :)

from path-to-regexp.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.