plibither8 / 2048.cpp Goto Github PK

Hi,

I am a total noob at C++ and I am using your project to experiment with the language. Reading the source code I came across this recursive call on Game::startGame which felt suspicious to me:

I thought this recursive strategy may cause a stack overflow if abused, for example like this:

$ yes 1 | build/2048.out > /dev/null 2>&1
[1]    28385 broken pipe                       yes 1 | 
       28386 segmentation fault (core dumped)  build/2048.out > /dev/null 2>&1

I don't think this is an important issue but I'd like to know why you used this strategy instead of a loop.

Thank you for the project it has been a very helpful resource to me.

I feel like the current structure of files and directories is inefficient and not clean. There should be better management of the source files and the build files, rather than all of them being in the root directory.

I am comparatively inexperienced with how larger C++ projects handle directory management. It would be great if a better management is suggested, and better yet, I'd welcome all PRs that implement such a structure. Thanks.

When I finish the installation and open the game, the coding seems to have some problems. Can you help me? Environment: Windows 10, MinGW.

鈹屸攢鈹€鈹€鈹€鈹€鈹€鈹€鈹€鈹€鈹€鈹€鈹€鈹€鈹€鈹€鈹€鈹€鈹€鈹€鈹€鈹€鈹€鈹€鈹€鈹€鈹€鈹€鈹?
鈹?SCORE: 0 鈹?
鈹?MOVES: 0 鈹?
鈹斺攢鈹€鈹€鈹€鈹€鈹€鈹€鈹€鈹€鈹€鈹€鈹€鈹€鈹€鈹€鈹€鈹€鈹€鈹€鈹€鈹€鈹€鈹€鈹€鈹€鈹€鈹€鈹?

鈹屸攢鈹€鈹€鈹€鈹€鈹€鈹攢鈹€鈹€鈹€鈹€鈹€鈹攢鈹€鈹€鈹€鈹€鈹€鈹?
鈹? 2 鈹? 鈹? 鈹?
鈹溾攢鈹€鈹€鈹€鈹€鈹€鈹尖攢鈹€鈹€鈹€鈹€鈹€鈹尖攢鈹€鈹€鈹€鈹€鈹€鈹?
鈹? 鈹? 鈹? 鈹?
鈹溾攢鈹€鈹€鈹€鈹€鈹€鈹尖攢鈹€鈹€鈹€鈹€鈹€鈹尖攢鈹€鈹€鈹€鈹€鈹€鈹?
鈹? 鈹? 2 鈹? 鈹?
鈹斺攢鈹€鈹€鈹€鈹€鈹€鈹粹攢鈹€鈹€鈹€鈹€鈹€鈹粹攢鈹€鈹€鈹€鈹€鈹€鈹?

W or K or 鈫?=> Up
A or H or 鈫?=> Left
S or J or 鈫?=> Down
D or L or 鈫?=> Right
Z or P => Save

Rather than having to ctrl+c to end the current game in progress, there could be an option to forfeit/quit the current game and return to menu.

I've noticed that there is already an CODE_HOTKEY_QUIT_ENDLESS_MODE that is somewhat similar to the proposed idea, but as far as I could tell, the endless mode is not yet implemented (is that right?).

when I wtite
"ctest -S setup.cmake"in git bash,
it shows
" Each . represents 1024 bytes of output
. Size of output: 0K
Error(s) when configuring the project
CMake Error at D:/Gitbase/2048.cpp/setup.cmake:53 (message):
Configure failed: return -1 cmake return -1
". But my cmake is newly installed. How to solve this problem? QAQ

There is a empty directory in source tree named build. there is nothing in it except an empty file. I strongly recommend to remove this directory.

I'm not sure why, but the character 1 keeps getting printed to the console for me. I'm using Zsh and GNOME Terminal. For example:

1   /\\\\\\\\\          /\\\\\\\                /\\\         /\\\\\\\\\    1
1  /\\\///////\\\      /\\\/////\\\            /\\\\\       /\\\///////\\\  1
1  \///      \//\\\    /\\\    \//\\\         /\\\/\\\      \/\\\     \/\\\  1
1             /\\\/    \/\\\     \/\\\       /\\\/\/\\\      \///\\\\\\\\\/   1
1           /\\\//      \/\\\     \/\\\     /\\\/  \/\\\       /\\\///////\\\  1
1         /\\\//         \/\\\     \/\\\   /\\\\\\\\\\\\\\\\   /\\\      \//\\\ 1
1        /\\\/            \//\\\    /\\\   \///////////\\\//   \//\\\      /\\\  1
1        /\\\\\\\\\\\\\\\   \///\\\\\\\/              \/\\\      \///\\\\\\\\\/   1
1        \///////////////      \///////                \///         \/////////     1



1  Welcome to 2048!1

          1. Play a New Game
          2. View Highscores and Statistics

  Enter Choice: 

Any ideas why this might be happening?

Basically user can go back to menu at anytime and can choose to exit application nicely instead of Ctrl+C.

Add Travis CI as an automated pre-check to help accept and merge all Pull Requests.

To prevent future incomplete and correctional merge requests, an automated Travis CI check would be very helpful.

This used to be available for pull requests in the project however this feature seems to have been lost / changed?

cd src & g++ *.cpp -o 2048 -I ./headers

When I have to shut down my computer or do other jobs but I haven't finished the game, I do NOT want to give up the game, I need to save the game intermediate progress. I think it's important!

The current demo gif on the repository's README page is alright, but it looks ugly when compared to the beautiful terminal gifs I have seen on other repositories (eg. Sindre Sorhus's repos). Anyone who can create a better gif than the current one, showcasing most of the features of the game (make sure to do a git pull), I'd be obliged. Thanks!

Steps to reproduce:

1. Download Visual Studio Code.
2. Install clang-format extension:
   
3. Download clang binaries from http://releases.llvm.org/download.html
4. Open a .cpp file
5. Right click > Format Document

Then I get this error:

I'll work on this.

🗺️ Many people around the world enjoy 2048.cpp 🕊️
However, English may not be the native language of many players.

The game should have some basic multilingual support so other players around the world:

• can enjoy the game in their native language.
• contribute translations of English text to their native language.

Compiled from git master 81c0eeb

  ┌───────────────────────────┐
  │ SCORE:               1156 │
  │ BEST SCORE:          1156 │
  │ MOVES:                127 │
  └───────────────────────────┘

  ┌──────┬──────┬──────┬──────┐
  │    2 │    4 │   32 │    4 │
  ├──────┼──────┼──────┼──────┤
  │    4 │    8 │    4 │    2 │
  ├──────┼──────┼──────┼──────┤
  │    8 │    2 │  128 │    8 │
  ├──────┼──────┼──────┼──────┤
  │   16 │   32 │    2 │   16 │
  └──────┴──────┴──────┴──────┘

  Game over! You lose.


  STATISTICS
  ──────────
  Final score:       0
  Largest Tile:      2
  Number of moves:   -1
  Time taken:        37s

Hmm, not really correct.

It should be:

  Final score:       1156
  Largest Tile:      128
  Number of moves:   127

And this is what shows up for View Highscores and Statistics:

  SCOREBOARD
  ──────────
  ┌─────┬────────────────────┬──────────┬──────┬───────┬──────────────┬──────────────┐
  │ No. │ Name               │ Score    │ Won? │ Moves │ Largest Tile │ Duration     │
  ├─────┼────────────────────┼──────────┼──────┼───────┼──────────────┼──────────────┤
  │  1. │ kc                 │        0 │   No │    -1 │            2 │       9m 22s │
  │  2. │ kc                 │        0 │   No │    -1 │            2 │          37s │
  └─────┴────────────────────┴──────────┴──────┴───────┴──────────────┴──────────────┘


  STATISTICS
  ──────────
  ┌────────────────────┬─────────────┐
  │ Best Score         │           0 │
  │ Game Count         │           2 │
  │ Number of Wins     │           0 │
  │ Total Moves Played │ 18446744073709551614 │
  │ Total Duration     │      9m 59s │
  └────────────────────┴─────────────┘

Not really a priority, but this is going to happen as number grows beyond 8192 😢, since current implementation uses std::setw(4) when prining each tile.

Gitflow-style repos [1] requires a develop branch.

All forked project's x-feature branches aim to merge with upstream's develop branch. The upstream's repo owner can then merge to the upstream's master branch when "safe and ready" to do so.
This method of source-code management may prevent severe merge problems / conflicts in the future.

1: https://nvie.com/posts/a-successful-git-branching-model/

I'm trying to compile this on Fedora, but it is failing.

/tmp/ccv0qRho.o: In function `main':
2048.cpp:(.text+0x26): undefined reference to `Menu::startMenu(int)'
collect2: error: ld returned 1 exit status

Project could use clang-format for formatting the source code so that it would be more generic across different contributors. More information here: https://clang.llvm.org/docs/ClangFormat.html

First of all, 👍 for awesome project!

One cool aspect of 2048 is derivatives, such as merging elements to get element with higher atomic number. Let's add support for such themes!

Sorry about the CI failure on the new github actions. I know it went wrong and I'll make a new PR to fix it in the next couple days thank you.

Currently, users have to follow 6 steps to install and run 2048. Though these are small and can be done quickly, it would be much more convenient if we have a bash script that does this for us.

The bash script will do the following:

1. Clone the repository in the home folder.
2. mkdir build, cd build to create the build directory.
3. cmake .. and make to create the final, executable program.

These are the 3 main steps that the script will follow. After this, we should add the 2048 program to the PATH so that users can access the game from anywhere in their terminal.

Either adding to the PATH permanently or adding an alias to the game in their .bashrc or .zshrc files.

With the bash script we can also now handle OS specific actions, as adding to the PATH will be quite different in all the three major OSs.

Platform

• Windows 10, MSVC 2017
• Commit: 71e6237

Issue:

• Just pulled to the latest commit on master and the game now looks like this:
  
• Additionally I always get the message 'clear' is not recognized as an internal or external command, operable program or batch file

std::endl is used everywhere while you should use \n instead of.

Should I end my output lines with std::endl or '\n'?

#using html and make website for University and college.

  ┌───────────────────────────┐
  │ SCORE:                192 │
  │ MOVES:                 31 │
  └───────────────────────────┘
 
  ┌──────┬──────┬──────┬──────┐
  │      │      │      │    2 │
  ├──────┼──────┼──────┼──────┤
  │    2 │      │      │    8 │
  ├──────┼──────┼──────┼──────┤
  │      │    2 │    4 │    4 │
  ├──────┼──────┼──────┼──────┤
  │    2 │    8 │   32 │   16 │
  └──────┴──────┴──────┴──────┘

  W or K or ↑ => Up
  A or H or ← => Left
  S or J or ↓ => Down
  D or L or → => Right
  Z or P => Save

Is it normal to not visible the best scorer?

Instead of exit application.

  STATISTICS
  ----------
  Final score:       11408
  Largest Tile:      1024
  Number of moves:   692
  Time taken:        1068.8 seconds

I think Time taken change to xx Hours xx Minutes xx Seconds can be more acceptable by human beings.

• Always occur segmentation fault after I enter the gameboard size.

Is this some sort of encoding issue? I'd appreciate any help.

OS: Windows 11 Version 10.0.22593 Build 22593

The highscore page goes into the endless cycle and prints new lines.

upd:
Name length issue. Can be reproduced by entering name with size >18.

Hi, we have 2048.cpp in MacPorts and it builds fine on OS X 10.11 and later, but on OS X 10.10 it fails to build. There are many errors in the log but the first is:

src/game-pregamemenu.cpp:139:42: error: no viable overloaded '='
  std::tie(loaded_gameboard, tempGBoard) =
  ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ^
/Library/Developer/CommandLineTools/usr/bin/../include/c++/v1/tuple:500:29: note: candidate function (the implicit move assignment operator) not viable: no known conversion from 'tuple<bool, struct GameBoard>' to 'tuple<std::initializer_list<bool> &, Game::GameBoard &>' for 1st argument
class _LIBCPP_TYPE_VIS_ONLY tuple
                            ^
/Library/Developer/CommandLineTools/usr/bin/../include/c++/v1/tuple:500:29: note: candidate function (the implicit copy assignment operator) not viable: no known conversion from 'tuple<bool, struct GameBoard>' to 'const tuple<std::initializer_list<bool> &, Game::GameBoard &>' for 1st argument
class _LIBCPP_TYPE_VIS_ONLY tuple
                            ^
/Library/Developer/CommandLineTools/usr/bin/../include/c++/v1/tuple:692:26: note: candidate template ignored: disabled by 'enable_if' [with _Tuple = std::__1::tuple<bool, Game::GameBoard>]
                         __tuple_assignable<_Tuple, tuple>::value
                         ^

We should be storing the game data in some centralised folder like/usr/lib/2048/ .

A (toplevel) .clang-format file would help developers clean up pre-committed source code before making PRs.

After I finish a game, the final statistics displayed and stored do not match my final score. The final score is always stored as 0, and the largest tile is always stored as 2. Number of moves is always stored as -1. Time taken is stored correctly.

To recreate this error:
Clone the git repo, install it to a local prefix, run the game, select new game, and lose a game.

I enjoyed the game and spent a good chunk of my work time making up to 1024. 😄
Just wanted to say Kudos. :)

enum class is a new C++ 11 feature and it has several advantages over enum, more detail here https://isocpp.org/wiki/faq/cpp11-language-types#enum-class

I fixed Color (#62) but later found more in other places. It isn't high priority but a good reason for refactoring code :)