pmartz / osgephemeris Goto Github PK

The _tzoff member variable is left uninitialized. This ensures it's initialized 
(to 0).

Checks pointer before dereferencing it.

What steps will reproduce the problem?
1. Checkout and build current OpenSceneGraph (2014-08-20 16:15:36)
2. Checkout and try to build osgephemeris


What is the expected output? What do you see instead?
Compilation should work but error occurs:
osgEphemeris/src/osgEphemerisLib/SkyDome.cpp: In member function ‘void 
SkyDomeUpdateCallback::_callDrawableCallbacks(osg::Geode*, 
osg::NodeVisitor*)’:
osgEphemeris/src/osgEphemerisLib/SkyDome.cpp:71:92: error: invalid conversion 
from ‘osg::Callback*’ to ‘osg::Drawable::UpdateCallback*’ [-fpermissive]
                     osg::Drawable::UpdateCallback *updateCallback = dbl->getUpdateCallback();
                                                                                            ^
osgEphemeris/src/osgEphemerisLib/SkyDome.cpp:71:92: error: cannot convert from 
base ‘osg::Callback’ to derived type ‘osg::Drawable::UpdateCallback’ 
via virtual base ‘osg::Callback’


What version of the product are you using? On what operating system?
Current SVN Rev 33 on Debian Jessie. Compiled with g++ 4.8.3 and CMake 2.8.12.2.


Please provide any additional information below.
In SkyDome.cpp line 71 replace:
osg::Drawable::UpdateCallback *updateCallback = dbl->getUpdateCallback();

with

osg::Drawable::UpdateCallback *updateCallback = 
dynamic_cast<osg::Drawable::UpdateCallback*>(dbl->getUpdateCallback());

Using printf() will try to print an uninitialized array to the console, which 
probably isn't what we want.

What steps will reproduce the problem?
1. Create an Osg Ephemeris Date Time.
2. Call now().


What is the expected output? What do you see instead?
The data time should have a date time that matches gmt, but instead the results 
are undefined because _tzoff is undefined.


What version of the product are you using? On what operating system?
This occurs on the trunk as of 1/26/14.  I tested it on OS X 10.9

Please provide any additional information below.

Here are the fixed constructors

DateTime::DateTime(
            uint32_t year,
            uint32_t month,
            uint32_t day,
            uint32_t hour,
            uint32_t minute,
            uint32_t second  )
: _tzoff(0)
{
    _tm.tm_year = year - 1900;
    _tm.tm_mon  = month - 1;
    _tm.tm_mday = day;
    _tm.tm_hour = hour;
    _tm.tm_min  = minute;
    _tm.tm_sec  = second;
    _tm.tm_wday = -1;
    _tm.tm_yday = -1;
    _tm.tm_isdst= -1;

    mktime(&_tm);
}

DateTime::DateTime( const DateTime &dt ):
    _tm(dt._tm), _tzoff(0)
{
    mktime(&_tm);
}

DateTime::DateTime(bool initialize)
: _tzoff(0)
{ 
   if( initialize )
   {
      now();
   }
}

DateTime::DateTime( const struct tm &tm )
: _tzoff(0)
{
    _tm = tm;
    mktime( &_tm );
}