I have some site collections that have site collection level app catalog(mysite/appcatalog not apps/appcatalog) and I want to deploy using pnp action, but Office 365 CLI only allows tenant admins to deploy.

Please allow site collection admins to deploy to the site that he owns.

Prompted by #16

This issue is to make this action consistent with the action-cli-login and enable us to update dependencies with confidence that we are not breaking existing functionality.

• Remove releases from readme
• Update maintainers
• Increment version number
• Create master from main
• Remove tslint
• Update tsconfig
• Update dependencies
• Update examples to use semver v2
• Add unit tests using mocha
• Add code coverage using c8
• Add test workflow
• Add PR check workflow
• Update action.yml
• Update to use node@18
• Update gitignore
• Set main branch as default branch
• Remove master branch
• Release new version to marketplace

We will have to perform few things to achieve this:

• Research how to publish GitHub action on the Marketplace
• Release version v1 (with tag included) of the GitHub action
• Publish the GitHub action on the marketplace

This is a related issue with pnp/cli-microsoft365#2080

Maybe include the solution that consist to replace UniqueId string from the returned result of the spo app add command.

GitHub recently added support for node@20 when creating JavaScript based GitHub actions. We should update the action metadata to ensure that we support the latest version of node.

https://docs.github.com/en/actions/creating-actions/metadata-syntax-for-github-actions#example-using-nodejs-v20

When this action is used to deploy a solution to SharePoint tenant from a Windows task runner the skipFeatureDeployment flag is not included in the command. This is due to the appId parameter including a return carriage character that escapes the string.

Steps to reproduce

1. Include this action in a GitHub Action using the windows-latest runner.

2. set SKIP_FEATURE_DEPLOYMENT to true.

The following log shows the --skipFeatureDeployment flag being printed on the following line rather than being included in the deploy command.

/usr/local/bin/o365 spo app add -p solution.sppkg --overwrite
 ***app-id***

/usr/local/bin/o365 spo app deploy --id ***app-id***
 --skipFeatureDeployment

See pnp/cli-microsoft365#5611

Because of this issue pnp/cli-microsoft365#2696, the GitHub action will fail because we will introduce some breaking changes to spo app add and spo app deploy.

For both commands, the option scope will be renamed to appCatalogScope. We should fix this when v6 of the CLI is released.

I'm getting an invalid option "scope" when deploying. Using v.2.

Per the help docs it looks like the flag should be -s

-s, --appCatalogScope [appCatalogScope] Scope of the app catalog: tenant,sitecollection. Default tenant

Not sure if this is something I configure in YAML file. Please advise.

Hi,
I would like to make a request about vulnerabilities detect in the security scan.
I have clone this repository and I haved passed a security scan. The Dependabot alerts show 3 vulnerabilities related to dependencies version included in the package-lock.json:

• path-parse version 1.0.6 --> fixed vulnerability in version 1.0.7 or later
• @actions/core version 1.2.1-->fixed vulnerability in version 1.2.6 or later
• minimist version 0.0.8 --> fixed vulnerability in version 0.2.1 or later

Please, I would like to know if there is any plan to upgrade these dependencies version in orden to eliminate le vulnerabilities.

Thanks in advanced

Source: https://github.com/pnp/action-cli-deploy/actions/runs/6525749892/job/17718797119?pr=28#step:9:24

(node:1788) Warning: To load an ES module, set "type": "module" in the package.json or use the .mjs extension.
(Use `node --trace-warnings ...` to show where the warning was created)

/home/runner/work/action-cli-deploy/action-cli-deploy/lib/commands.spec.js:1
import * as assert from 'assert';
^^^^^^

SyntaxError: Cannot use import statement outside a module
    at internalCompileFunction (node:internal/vm:73:18)
    at wrapSafe (node:internal/modules/cjs/loader:1178:20)
    at Module._compile (node:internal/modules/cjs/loader:1220:27)
    at Object.Module._extensions..js (node:internal/modules/cjs/loader:1310:10)
    at Module.load (node:internal/modules/cjs/loader:1119:32)
    at Function.Module._load (node:internal/modules/cjs/loader:960:12)
    at ModuleWrap.<anonymous> (node:internal/modules/esm/translators:169:29)
    at ModuleJob.run (node:internal/modules/esm/module_job:194:[25](https://github.com/pnp/action-cli-deploy/actions/runs/6525749892/job/17718797119?pr=28#step:9:26))

Office 365 CLI deploy GitHub action

GitHub action to deploy an app using Office 365 CLI

This GitHub Action (created using typescript) uses Office 365 CLI, specifically the spo app add, spo app deploy and spo app install commands, to add, deploy and (if site collection) install an app.

Usage

Pre-requisites

Create a workflow .yml file in your .github/workflows directory. An example workflow is available below. For more information, reference the GitHub Help Documentation for Creating a workflow file.

Dependencies on other GitHub Actions

• Office 365 CLI Login – Required . This action is dependant on action-cli-login. So in the workflow we need to run action-cli-login before using this action.

Inputs

• APP_FILE_PATH : Required Relative path of the app in your repo.
• SCOPE : Scope of the app catalog: tenant|sitecollection. Default tenant.
• SITE_COLLECTION_URL : The URL of the site collection where the solution package will be added and installed. It must be specified when the scope is sitecollection.
• SKIP_FEATURE_DEPLOYMENT : true|false If the app supports tenant-wide deployment, deploy it to the whole tenant.
• OVERWRITE : true|false Set to overwrite the existing package file.

Output

• APP_ID : The id of the app that gets deployed

This is more of a question rather than an actual issue. We are experiencing caching issues whend deploying SPFX app to SharePoint similar to SharePoint/sp-dev-docs#8915. I'm wondering if there is something that can be done via this action or m365 cli - to flush all existing assets before deploying (contents of .spkkg file). Thanks.

Description: Update the documentation where the examples use master instead of v.1.x.x. Change from pnp/[email protected] to pnp/action-cli-deploy@master.

This will guarantee that users that follow the docs get the latest version of the action with all the fixes and enhancements.

Originates from: #11 (comment)

Apparently we broke the GitHub action flow by defining the default output in the CLI runtime. Because of this issue: pnp/cli-microsoft365#3445

Our default output value used to be undefined, by refactoring this to json, the command will now return the entire app object instead of just the ID.

https://github.com/pnp/cli-microsoft365/blob/e42aed1530b6755b2485a944bbd9a251aac3fddb/src/m365/spo/commands/app/app-add.ts#L127-L132

Therefore these lines of code will fail:

🤔 Problem

Since CLI is interactive by default in logs we will see that CLI shows the spinner.

Although it does not break the step and produce no harm it is just not needed/wanted log that we should avoid

🐞🔨 Fix proposal

To resolve this we should run m365 setup —scripting —output none at the beginning of the action so that CLI will not present any interactive response