Comments (11)
Do you have a code style manual?.
The style of the variable names, function names, design patterns to use, etc.
Perhaps is a good idea to create one and accept only the pull request that use this guide.
from pokemonunity.
I've made a change to the PokemonDatabase class to optimize a lot the access to it.
How could I make a pull request for that change?
from pokemonunity.
@joseka1234 answer @superusercode, he will help you ^^
from pokemonunity.
Thank you @cataclys but, how can I ask him?
I'm a bit useless using the GitHub web.
from pokemonunity.
pm him on Discord => superusercode#3623
from pokemonunity.
Thanks!
from pokemonunity.
I see there's some documentation written for users of the framework, but none for the developpers (i.e. internal functioning, class diagrams and relations...).
Is there any document hanging around that I haven't seen that describes a general picture of how all the scripts work with each other or something? Just to grab the big picture of the framework and get a hold of it, to make it easier (and faster) to start developing for it.
from pokemonunity.
Unfortunately, no. We're still in the early stages of rewriting large chunks of legacy code because of how fast Unity evolves. When the framework was left it was, and still is, a mess. If you want to help us, make sure you talk to us in the Discord server. Thanks for your interest!
from pokemonunity.
hello i am interested in helping develop Pokemon unity i have 8 years of c# and unity knowledge under me i can even send some examples.
from pokemonunity.
@DeathClown64 If you're interested in contributing just send a pull request to the repository, and we'll update it with your code. At the moment, i am not investing any attention into the Master
branch or develop
branch. But if it's what you prefer to work on/with, feel free to submit and i'll add it to code (if it works).
There are some Unit Testing code on develop-beta
branch, you can always start there, if you REALLY want something immediate to work on. Else, there's a ton of To-Do's
scattered about in the code. If you're using visual studio as your IDE, there should be a way to list each one in a window. I can't tell you what to do. So if you want to help, work at your own pace, and send over whatever you got. That's pretty much about it.
from pokemonunity.
from pokemonunity.
Related Issues (20)
- Walking Bugs HOT 3
- Move dependencies in scripts out of Resources folder
- [Meta] Relation with herbertmilhomme/PokemonUnity HOT 1
- Replace Beta with PR #109 HOT 3
- Linux 64-bit HOT 1
- README
- KeyNotFoundException at Assets/Scripts/Player.cs:44 HOT 1
- Crashes when I leave Gold's house in alpha branch HOT 2
- Pokemon HOT 1
- A FAQ would be awesome HOT 6
- Sample scene empty almost HOT 2
- Array Index Out of Bounds in scene overworldNW HOT 5
- Webgl demo link is not working HOT 1
- Build errors! HOT 5
- Sprites are not properly being scaled down by canvas UIs HOT 1
- English Text & Translations Is Poorly Written HOT 3
- Rename PKU Beta to API? HOT 5
- [Archive] Questions on Map Development HOT 2
- Directory and File Hierarchy Should Be Restructured?
- Beta needs restructuring?
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from pokemonunity.