Should setCamera() also call resetMatrix()? about p5.js HOT 6 CLOSED

Right, I guess the rule would be, set the camera before you draw the content?

Also, we have this PR basically ready to start testing as soon as we're done making quick docs releases for the website release: #6761 I think after this change, since the camera and model transform matrices will not be merged into a single variable, we actually might not need to reset at all, since we'll be able to discern what part came from transforms vs what part came from the camera. So maybe the thing to do is to wait until we can merge and test to see if that refactor fixes this for us? (The reason for the wait is that it's a pretty big change to a core part of the rendering algorithm, which I think warrants a beta testing period before release, which we've been skipping for our expedited docs releases.)

from p5.js.

@davepagurek would this approach also affect/reset transformations applied elsewhere in code?

from p5.js.

I think it would only affect transforms if you're calling setCamera in the middle of draw rather than in setup or in an event handler. But if you were previously calling setCamera mid-draw, arguably the resulting things you draw wouldn't have been in the correct spot anyway since they wouldn't be using the camera's transform yet?

from p5.js.

As long as the reference is clear about where/when to call setCamera() I think we're good. This test case is a little contrived but it surprised me.

from p5.js.

Agreed that beta testing for this kind of change is a good call.

from p5.js.

Just put up #7067 with something that augments #6761 so that only the view matrix updates when you change cameras. We can play around with that and see if there are any situations that would cause issues

from p5.js.