purestorage-openconnect / purestorage.flasharray.vmware Goto Github PK

Remove-PfaVasaProvider throws an error but does remove the VASA providers. I believe this is because it calls get-pfaVasaProvider after there are no more providers but doesnt handle the error correctly. Will look into this

Currently the new-pfavmfs cmdlet just automatically specifies the name when creating a VMFS from a snapshot. For new VMFS volumes you can specify the name. Some customers want to be able to do this for copied datastores too. I will work on adding the -volumeName parameter to this parameter set.

Create a new object type that represents a Pure policy--making it easy to map new capabilities and data types in PowerShell.

Get-PfaAppliance does not currently work with non-Windows machines

Need to find the code that causes this error to be thrown and use a new method that doesn't have a deprecation warning.

When invoking these cmdlets, the rest API call fails because the .Endpoint value passed includes the protocol, and not just the FQDN/IP.

currently you cannot specify a server, this can cause issue if multiple connections exist.

There are reports of the PowerShell install method of the plugin does not work when the vCenter has a proxy. While this may be more environmental (can the proxy route to S3) this should be tested and understood.

If you do not enter a VASA array, datastore or FA it fails ugly.

Looks like the module blocks underscores in naming (or has some issue with it) I will take a look at this and fix it.

Remove the extra "l" of "get-pfaConnectionlfromRDM" in code could fix this.

-----------Error message-------------
PS> remove-pfaVolRDM -rdm $rdm -flasharray $purepoc01
get-pfaConnectionlfromRDM : The term 'get-pfaConnectionlfromRDM' is not recognized as the name of a cmdlet, function, script file, or operable program. Check the spelling of the name, or if a path was included, verify that the path is correct and try again.

Currently Get-PfaVasaProvider requires a FA connection and will then return the active provider for that FA. Sometimes you might want to know all active Pure providers. So update this cmdlet to not require a FA connection and then return all providers.

For 90% of the use cases, installing the most recent plugin will generally be used. However, in the event that a new plugin version is causing problems, has a bug or in the end the customer needs to install a older version we should make sure we have at least one version behind the newest available to install.

"Out-Nul: /Users/dstamen/.local/share/powershell/Modules/PureStorage.FlashArray.VMware.VVol/PureStorage.FlashArray.VMware.vVol.psm1:716
Line |
716 | … $sourceFaVolume)`""}"" -SkipCertificateCheck -ErrorAction Stop |Out-Nul
| ~~~~~~~
| The term 'Out-Nul' is not recognized as the name of a cmdlet, function, script file, or operable program. Check the spelling of the name, or if
| a path was included, verify that the path is correct and try again."

Assigns a FlashArray storage policy to a vVol VM and optionally a replication group.

Set-PfaRDMCapacity -rdm $disk -sizeInGB 11 -flasharray $array -offlineConfirm
Set-PfaRDMCapacity: Cannot process argument transformation on parameter 'flasharray'. Cannot convert the "PurePowerShell.PureArray[]" value of type "PurePowerShell.PureArray[]" to type "PurePowerShell.PureArray".

Create a cmdlet to easily find replication group partners for vVols

Uninstall plugin cmdlet does not currently support more than one vCenter.

Some cmdlets used snapname as the parameter when it should be suffix. There have been deprecation warning on them. Removing them in the next release.

Something like Remove-PfavSpherePlugin should work, but essentially we'll need a way for the end user to uninstall the plugin. Why is this important? Mostly for the use case of downgrading the plugin or uninstalling the flash plugin completely.

Create cmdlet to edit policies

Returns all available FlashArray Storage policies. Optional parameter of -replication for replication type policies

Current error does not show size difference, so the user has to figure out what the exact size is. Should show existing size and new erroneous size.

Cmdlet to return FlashArray type VASA storage arrays. Takes in a name, serial, or FA connection, or nothing.

Protection group replicated snapshot from arrayA to arrayB is named arraya:protectiongroup.snapshotsuffix.volumegroup/volumename which fails on new-pfavolume with invalid name. Tried without volumegroup with the same result. Seems like colon in the snapshot name is being passed to new-pfavolume and returning the following error:

New-PfaVolVmfsFromSnapshot -cluster $arraybcluster -flasharray $arrayb -snapName arraya:protectiongroup.snapshotsuffix.volumegroup/volumename

New-PfaVolume : [{"msg": "Volume name must be between 1 and 63 characters (alphanumeric, '_' and '-') in length and begin and end with a letter or number. The name must include at least one letter.", "code": 19, "ctx": "ArrayA:ProtectionGroup-snap-5862"}] At C:\Program Files\WindowsPowerShell\Modules\PureStorage.FlashArray.VMware.VMFS\1.1.0.2\PureStorage.FlashArray.VMware.VMFS.psm1:717 char:12
+ $newVol =New-PfaVolume -Array $flasharray -Source $snapName -Volume ...
+ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ + CategoryInfo : NotSpecified: (:) [New-PfaVolume], PureRestException + FullyQualifiedErrorId : PurePowerShell.NewVolumeCmdlet

Need a parameter to rename the newly copied volume on arrayb.

Cannot process argument transformation on parameter 'flasharray'. Cannot convert the "PurePowerShell.PureArray[]" value of type | "PurePowerShell.PureArray[]" to type "PurePowerShell.PureArray"

Even through the thumbprint matches, the install-pfavsphereplugin is failing to install the plugin due to 403 thumbprint error.

Looks like this will not work on Unix systems. Will look into this for the next release.

Convert-PfaRDMtoVvol: Cannot process argument transformation on parameter 'flasharray'. Cannot convert the "PurePowerShell.PureArray[]" value of type "PurePowerShell.PureArray[]" to type "PurePowerShell.PureArray". Additionally it unmounts the RDM from the VM & does not resize it.

Add the ability to clear attributes upon uninstall of the plugin. Probably make it an opt-in option, like -clearCredentials or something.

If a consistency group is populated in a policy, the auto replication group choice will fail. We should block this combination in the cmdlet as the reason for failure is not clear.

Should be able to pull FlashArray connection if new-pfaconnection was used to authenticate in RDM cmdlets

It currently filters for 5.5.* and 6.*

Deploy-PfaAppliance does not currently work with non-Windows machines

Initialize-PfaVcfWorkloadDomain does not currently support core.

Return all FlashArray fault domains. Optional input FlashArray connection

Feature Request

Not allowing custom suffix for vVol unmanaged snapshot

Creates a storage policy from a replication group, or various inputs.

The cmdlet allows you to create RDMs from a snapshot, this was broken when a name change occured--it should be snapshot, not snapshotname.

Follow Pascal case for all cmdlets

Return replication groups that are just for the FlashArray, filter by policy or datastore. -Target or -Source parameter.

The port group parameter didn’t seem to work with distributed port groups. I had to create a standard vswitch and port group to get it to work.

Deploy-PfaAppliance : Cannot process argument transformation on parameter ‘portGroup’. Cannot convert the “dvspg-name” value of type
“VMware.VimAutomation.ViCore.Impl.V1.Host.Networking.DistributedPortGroupImpl” to type
“VMware.VimAutomation.ViCore.Types.V1.Host.Networking.VirtualPortGroup”.

Infinite loop trying to remove provider:

Remove-VasaProvider -Provider $vasaProvider -Confirm:$fal … | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ | 8/30/2020 4:47:07 PM Remove-VasaProvider Object reference not set to an instance of an object.

Works if the Snap is named correctly, but unmounts & doesn't reattach if the snap doesn't exist. Suggest verifying the snap exists 1st.

Good idea.

Add support for this: https://www.codyhosterman.com/2020/04/whats-new-in-vsphere-7-0-storage-part-iii-guestinfo-virtualdiskmapping-linux-powercli-support/

Module does not autoload in Core, I believe this is a default behavior in core, but worth a look into.

There has been a reported issue around the uninstaller not uninstalling the plugin. No details yet, but opening this issue to track the issue.

Currently this module is only supported on Windows and has not been tested with core. Certain cmdlets certainly do not work on core. Will work on adding core support.