ranaalisaeed / d3-webpack-babel-typescript Goto Github PK

Add Production workflow that exports the chart library so that it can be imported as Node library

Implement unit testing workflow using Jest.
My initial notes about Jest implementation from an earlier project:

Tried Jest and everything works! I get all tests passing and get coverage. There is very little setup required for Jest to work as well and there is a lot of things that can be cleaned up from the code.

In terms of config, here are thing to be added:

• jest config in package.json (including script command)
• babel.config.js file for babel-jest transform to work
• jest-codemods to updated the test files

Here are things that can be removed:

• webpack.test.js config is not longer required
• all sinon complexities go away from the test file as well inside webpack to make it work
• "ali:test": "webpack --config build-utils/webpack.test.js && mocha --require jsdom-global/register test-dist/bundle.test.js && rm -rf test-dist", all these things can be removed
• remove mocha, chai, glob, jsdom, jsdom-global
• delete webpack.test.js file

Test failing where we need to get categories from data as getCatories was not an exposed API function.

   API
      ✕ should provide maxValue getter and setter (22 ms)
      ✓ should provide an event "on" getter and setter (25 ms)
      margin
        ✓ should provide margin getter and setter (20 ms)
        when margins are set partially
          ✓ should override the default values (26 ms)

  ● Stackbar Chart › API › should provide maxValue getter and setter

    TypeError: stackbarChart.categories is not a function

      404 |
      405 | 		test('should provide maxValue getter and setter', () => {
    > 406 | 			const sample_categories = stackbarChart.categories()
          | 			                                        ^
      407 | 			const data_maxVal = max(
      408 | 				sample_data.map(d => max(
      409 | 					[sum(sample_categories.map(k => d[k]))]

      at Object.test (src/charts/stackbar.test.ts:406:44)

Between Dev, Demo, Prod workflows, there are repeating parts that need to be made DRY
Implement merge functionality provided by webpack

D3 library has to be imported using:
import * as d3Fetch from 'd3-fetch'

Error:

export 'default' (imported as 'd3Fetch') was not found in 'd3-fetch' (possible exports: blob, buffer, csv, dsv, html, image, json, svg, text, tsv, xml)

what is needed to convert to
import d3Fetch from 'd3-fetch'

Add Demo workflow that shows a demo of the chart library

• Check Types with TypeScript
• Build Type definitions with TypeScript
• Build JavaScript output with Babel