CDN's for clippy are down about react95 HOT 7 CLOSED

🤔

It is probably related to this commit which comes as solution for #218

So, it looks like gitcdn isn't the best provider. Although it is faster, sometimes it comes down (don't know why).
We can rollback this changes but need to check window conditionally before setting this new env variable.
Easy fix, I guess.

I'd love to have your contribution on this, @Mrpanquecas. What do you think?

from react95.

I can give it a try tonight, more than eager to help.

from react95.

Do I need specific permissions to contribute? @ggdaltoso

from react95.

You shouldn't!

Just fork the project and make sure to follow our contribution guidelines

from react95.

I created this pr but I don't really know how to test clippy locally on story book :)

I thought a little bit about this issue and I'm not sure conditionally checking for the window will solve this problem since the code running on server the window property will always be undefined and as a consequence we will never be able to use the S3 CDN. Does it makes sense?

from react95.

Yes, it does!

As soon as this code runs in the server, it would get into the falsy condition. When the code reaches the browser, the window will be available and the CDN will be changed.

Clippy will work only on the client side and not in the server side so, your solution will work as expected (I hope 😂)

We might need something better to test Clippy, you're right. Maybe we can get a CRA into its package, just to run and test the Clippy. Would you like to contribute one more time?

from react95.

Yes more than happy to contribute. I think I will need a little bit more time to figure how everything works as I am not used to contribute to this kind of packages 😅 .

from react95.