Scrolling issue in storybook about react95 HOT 3 CLOSED

I noticed it yesterday 😂

We had overflow previously on GlobalStyle but it wasn't the right place to add it.
@rfoel proposed some changes and we shipped a new version with the fix a while ago.

But removing the overflow from GlobalStyle breaks places where it is necessary, as you noticed. I think this can be fixed in some storybook configuration.

Would you like to contribute?

from react95.

Would you like to contribute?

I'm not super familiar with Storybook config stuff and thus was hesitant to open a PR, but I'd be open to fork it and fix it. I'll put up a PR at some point in the next few days and close out this issue.

Read thru the CONTRIBUTING.md, anything else I should be aware of before I put up a PR?

from react95.

After thinking more about this, I think the best approach here would be to revert #376 as the GlobalStyle doesn't try to mimic a Windows95 screen. So, removing this line will fix the issue. Don't need to worry about storybook config.

I'd also encourage you to play around with all the components if you don't mind. Maybe you'll find more places to contribute, who knows... 😃

from react95.