Comments (5)
redstreet
commented on September 11, 2024
Agreed, it should be ignored. However, there's no safe way aa_class can automatically infer this. Hence, this is done via configuration. Have you tried to configure the plugin, and if so, I'd be interested if you ran into issues.
from fava_investor.
redstreet
commented on September 11, 2024
It would be good for the example to exclude Assets:US:Hooli:Vacation in its configuration regex to illustrate this case. PR welcome.
from fava_investor.
nils-werner
commented on September 11, 2024
Can't the plugin simply ignore commodities that don't have an asset class configured?
from fava_investor.
redstreet
commented on September 11, 2024
It could, but that would risk ignoring assets where one has simply forgotten to configure the asset class. Everything would seem fine, and there's no way to tell that the result being shown is incorrect.
I've run into this enough myself and decided explicit is better than implicit.
from fava_investor.
redstreet
commented on September 11, 2024
Closing. Feel free to open if there are further thoughts.
from fava_investor.
Related Issues (20)
- Incorrect proceeds because sale price not used HOT 3
- Fava Investor won't load HOT 3
- Function get_account_open in favainvestorapi.py returns an empty list HOT 3
- Incorrect allocation percentage computation in "Asset Allocation Accounts" HOT 4
- Fava QueryShell Change HOT 5
- Need a good example.beancount that demonstrates all modules
- [Feature] Write errors to GUI callout instead of exiting HOT 3
- [Feature] Sum up allocation sub classes HOT 3
- [Feature] Allow filtering for accounts HOT 1
- [Feature] Use implicit prices HOT 2
- [Feature] Asset allocation tools
- Fava investor tab fails to load HOT 8
- Asset Allocation Classes-- TypeError: unsupported operand type(s) for /: 'str' and 'int' HOT 3
- Asset Allocation by Class does not convert prices transitively HOT 3
- New fava version breaks fava-investor HOT 3
- Fava 1.26.2 breaks fava _investor HOT 3
- Asset allocation display is broken in Fava 1.25 onwards
- cannot import name 'cost_or_value' from 'fava.template_filters' HOT 3
- Multicurrency Asset Allocation in Fava HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from fava_investor.