Giter VIP home page Giter VIP logo

Comments (3)

redstreet avatar redstreet commented on September 11, 2024

It does work already. See #32 on how to configure it.

from fava_investor.

korrat avatar korrat commented on September 11, 2024

Thank you for pointing me in the right direction. I should have checked the examples more carefully.

I took a look at the asset allocation module and came across this line:

vbalance = balance.reduce(convert.get_units)

Would it be possible/sensible to reduce the inventory directly using convert.convert_position? This way, we would get conversions via the cost currency โ€œfor freeโ€ when there is no direct conversion possible.

This would be equivalent to the BQL query I gave.

from fava_investor.

redstreet avatar redstreet commented on September 11, 2024

Np at all, the doc on this is not obvious. I just added a reference to #32 to the README.

Reg convert.convert_position: interesting, and good to know. It's been a while since I wrote this, and I can't recall if that's something I tried and know doesn't work, or if it's something I never considered.

Have you tried it? If you can confirm that it works as expected, would you be up for submitting a PR, possibly with new test cases if needed? Thanks!

from fava_investor.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.