Comments (5)
I did some shallow digging, and came up with a candidate for a fix for this issue: #70
I've attempted to gate the change based on the fava version, but I confess I have not tested it with earlier versions (fava < 1.22) to ensure it still works.
from fava_investor.
Awesome, thanks for catching these bleeding edge issues. I tend to be slow to ugprade versions, so I'm glad you seem to be on the other end :-) +1
Left a comment on the PR. Once ready, I'll test on (fava < 1.22) before merging.
Sounds good! I'll take a look and address it in the next few days as I can.
And FYI, it appears there is another possible issue that I'm now hitting with the latest upstream fava where the output from fava_investor is being output without error by fava, but as raw, un-rendered HTML. I'm suspecting this is another API change we'll need to work around, but haven't yet made time to 1) confirm its not something that I've broken and 2) triage it. So there may be an additional fix coming.
from fava_investor.
And FYI, it appears there is another possible issue that I'm now hitting with the latest upstream fava where the output from fava_investor is being output without error by fava, but as raw, un-rendered HTML. I'm suspecting this is another API change we'll need to work around, but haven't yet made time to 1) confirm its not something that I've broken and 2) triage it. So there may be an additional fix coming.
It looks like this was an issue in Fava itself: beancount/fava#1440
from fava_investor.
Awesome, thanks for catching these bleeding edge issues. I tend to be slow to ugprade versions, so I'm glad you seem to be on the other end :-) 👍
Left a comment on the PR. Once ready, I'll test on (fava < 1.22) before merging.
from fava_investor.
BTW: I made this change in 757fc20 (in addition to a03223a) so all modules now respect the UI context. Still waiting on beancount/fava#1467 to complete it.
If you happen to test this out, feedback is appreciated 😃 .
from fava_investor.
Related Issues (20)
- Postive amounts of non-monetary commodities crash aa_class HOT 5
- Incorrect proceeds because sale price not used HOT 3
- Fava Investor won't load HOT 3
- Function get_account_open in favainvestorapi.py returns an empty list HOT 3
- Incorrect allocation percentage computation in "Asset Allocation Accounts" HOT 4
- Need a good example.beancount that demonstrates all modules
- [Feature] Write errors to GUI callout instead of exiting HOT 3
- [Feature] Sum up allocation sub classes HOT 3
- [Feature] Allow filtering for accounts HOT 1
- [Feature] Use implicit prices HOT 2
- [Feature] Asset allocation tools
- Fava investor tab fails to load HOT 8
- Asset Allocation Classes-- TypeError: unsupported operand type(s) for /: 'str' and 'int' HOT 3
- Asset Allocation by Class does not convert prices transitively HOT 3
- New fava version breaks fava-investor HOT 3
- Fava 1.26.2 breaks fava _investor HOT 3
- Asset allocation display is broken in Fava 1.25 onwards
- cannot import name 'cost_or_value' from 'fava.template_filters' HOT 3
- Multicurrency Asset Allocation in Fava HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from fava_investor.