SteamNetworkingSockets.ConfigureConnectionLanes has incorrect parameter types; can't be called correctly about steamworks.net HOT 9 CLOSED

I updated Steamworks.NET in the Unity Package Manager window and can now successfully call the API. Thanks for getting this fixed so quickly!

from steamworks.net.

Not sure if we can put PR for this, seem the repo almost out of life.
Add this in CodeGen/src/interfaces.py:

g_TypeDict = {
    ...
    "const int *": "ref int",
    "const uint16 *": "ref ushort",
    ...
}

from steamworks.net.

Thanks for the tip. ref int and ref ushort would only allow passing 1 int and 1 ushort, which also doesn't match the native method signature. Is it valid to specify int[] and ushort[]? I've seen some other methods that have parameters with the byte[] signature

from steamworks.net.

oh right sorry, didn't see the header file completely, yeah then that works

from steamworks.net.

Can you verify that int[] and ushort[] work?

If so we can get that change in this weekend. I think the spot to make a change is in g_SpecialArgsDict

from steamworks.net.

I'll give it a try and see if I can put a PR together; might not happen until the work week

from steamworks.net.

I don't need a full PR, I can do that pretty quickly, what I can't really do right now is verify that it works.

To test locally without having to regenerate everything you'd need to make two manual changes to both:

Ultimately they should probably end up looking like say this: https://github.com/search?q=repo%3Arlabrecque%2FSteamworks.NET%20pvecDepots&type=code

from steamworks.net.

Thanks Riley

I made a mutable local copy of the Unity package and compiled successfully with the edits shown below. The method call succeeds at runtime and received k_EResultOK using this invocation:

Invocation:

var lanesResult = SteamNetworkingSockets.ConfigureConnectionLanes(conn, 3, new int[] {1, 2, 3}, new ushort[] {4, 5, 6});

Package edits:

[DllImport(NativeLibraryName, EntryPoint = "SteamAPI_ISteamNetworkingSockets_ConfigureConnectionLanes", CallingConvention = CallingConvention.Cdecl)]
public static extern EResult ISteamNetworkingSockets_ConfigureConnectionLanes(IntPtr instancePtr, HSteamNetConnection hConn, int nNumLanes, [In, Out] int[] pLanePriorities, [In, Out] ushort[] pLaneWeights);

public static EResult ConfigureConnectionLanes(HSteamNetConnection hConn, int nNumLanes, int[] pLanePriorities, ushort[] pLaneWeights) {
	InteropHelp.TestIfAvailableClient();
	return NativeMethods.ISteamNetworkingSockets_ConfigureConnectionLanes(CSteamAPIContext.GetSteamNetworkingSockets(), hConn, nNumLanes, pLanePriorities, pLaneWeights);
}

public static EResult ConfigureConnectionLanes(HSteamNetConnection hConn, int nNumLanes, int[] pLanePriorities, ushort[] pLaneWeights) {
	InteropHelp.TestIfAvailableGameServer();
	return NativeMethods.ISteamNetworkingSockets_ConfigureConnectionLanes(CSteamGameServerAPIContext.GetSteamNetworkingSockets(), hConn, nNumLanes, pLanePriorities, pLaneWeights);
}

from steamworks.net.

Thanks @Idles ! Whenever you get a chance can you make sure that new commit fixes this accurately?

from steamworks.net.