Cannot build the devices with ROS 2 Iron about yarp-devices-ros2 HOT 20 CLOSED

The fix was merged upstream in ament/ament_cmake#484. Looking at the history of iron syncs (see https://discourse.ros.org/tag/iron), I think we could expect the fix to land in .deb in a few weeks.

from yarp-devices-ros2.

That should work, yes.

from yarp-devices-ros2.

I proposed a fix upstream in ROS 2 Iron in ament/ament_cmake#484 . However, even if it is accepted it would take some time to have it released as a .deb package, so we may want to find a workaround in the meanwhile.

from yarp-devices-ros2.

@xEnVrE thanks for the reply. I asked about cmake because I get the same exact error that you shown.
The issue has definitely something to do with CMake because when I change the order in which the two ros2_interfaces_ws packages folders are added, the error that @PasMarra has shown is not triggered by yarp_control_msgs but by map2d_nws_ros2_msgs. I'll try to come up with a solution tomorrow.

Thanks again for opening this issue

from yarp-devices-ros2.

Possibily related to ament/ament_cmake#460 .

from yarp-devices-ros2.

@traversaro I can check if it works, just the time to setup the docker container and I'll let you know!

from yarp-devices-ros2.

Sorry, there was a stupid bug, can you try in a clean build updating after 10351e6 ?

from yarp-devices-ros2.

You are right, my environment was dirty. I played a bit but I could not find an easy workaround.

from yarp-devices-ros2.

Hi @PasMarra, do you get, by any chance, an error message also from cmake?

from yarp-devices-ros2.

I think we also got the following errors at CMake-level:

CMake Error: Files to be generated by multiple different commands: "/home/user/yarp-devices-ros2/build/ament_cmake_environment_hooks/ament_prefix_path.dsv"
CMake Error: Files to be generated by multiple different commands: "/home/user/yarp-devices-ros2/build/ament_cmake_environment_hooks/library_path.dsv"

I have reproduced it again using also ros rolling. I am start thinking the problem might be due to CMake itself.

from yarp-devices-ros2.

Thanks a lot, that means that, meanwhile, as we only need yarp_control_msgs, we can just disable the nav part and we should be able to continue?

from yarp-devices-ros2.

This is a regression related to ament/ament_cmake#416, see also the related comment.

from yarp-devices-ros2.

@PasMarra @xEnVrE can you check if #62 solves the problem? Remember to try it on a clean build, as otherwise the AMENT_CMAKE_ENVIRONMENT_PACKAGE_GENERATION option is already initialized to ON.

from yarp-devices-ros2.

Remember to try it on a clean build

Maybe it is a dumb question, is it ok if I remove the build folder of yarp-devices-ros2 to achieve that or do you mean something different ros2-wise?

If a standard build clean is what you meant, I have already tried it but I keep receiving the error:

-- Configuring done
CMake Error: Files to be generated by multiple different commands: "/home/user/yarp-devices-ros2/build/ament_cmake_environment_hooks/ament_prefix_path.dsv"
CMake Error: Files to be generated by multiple different commands: "/home/user/yarp-devices-ros2/build/ament_cmake_environment_hooks/library_path.dsv"
-- Generating done
CMake Generate step failed.  Build files cannot be regenerated correctly.

from yarp-devices-ros2.

If a standard build clean is what you meant, I have already tried it but I keep receiving the error:

Yes, I mean removing the build directory (not make clean). It is strange you still get the problem, what is the output of (please run in the build directory):

cat CMakeCache.txt | grep AMENT_CMAKE_ENVIRONMENT_PACKAGE_GENERATION 

from yarp-devices-ros2.

What I did was

rm -rf build
mkdir build
cd build
cmake ../

Then I get the errors above.

The output of what you asked is then:

AMENT_CMAKE_ENVIRONMENT_PACKAGE_GENERATION:BOOL=ON

from yarp-devices-ros2.

Considering the last change I get

-- Configuring done
CMake Error: Files to be generated by multiple different commands: "/home/user/yarp-devices-ros2/build/ament_cmake_environment_hooks/ament_prefix_path.dsv"
CMake Error: Files to be generated by multiple different commands: "/home/user/yarp-devices-ros2/build/ament_cmake_environment_hooks/library_path.dsv"
-- Generating done

and

cat CMakeCache.txt | grep AMENT_CMAKE_ENVIRONMENT_PACKAGE_GENERATION 
AMENT_CMAKE_ENVIRONMENT_PACKAGE_GENERATION:BOOL=OFF

from yarp-devices-ros2.

Thanks for the update @traversaro

from yarp-devices-ros2.

The fix was merged upstream in ament/ament_cmake#484. Looking at the history of iron syncs (see https://discourse.ros.org/tag/iron), I think we could expect the fix to land in .deb in a few weeks.

Actually that was just a merge in rolling, the backport PR to iron got stuck: ament/ament_cmake#487 .

from yarp-devices-ros2.

The fix was merged upstream in ament/ament_cmake#484. Looking at the history of iron syncs (see https://discourse.ros.org/tag/iron), I think we could expect the fix to land in .deb in a few weeks.

Actually that was just a merge in rolling, the backport PR to iron got stuck: ament/ament_cmake#487 .

The PR was merged, and it was released in February: ament/ament_cmake@ff9a01f and https://discourse.ros.org/t/patch-release-4-and-new-packages-for-iron-irwini-2024-02-09/36006, I think we can safely close this issue.

from yarp-devices-ros2.