CreateLauncher: needs to be ported to generator expressions - else violates policy (use of the LOCATION) -> CMP0026 about cmake-modules HOT 9 CLOSED

Right, so this will require some sizeable re-writing. It should make it simpler, the catch is that it will make it hard to support both pre-generator-expression and post-generator-expression CMake version. I imagine the best course there is to actually have two separate implementation files.

from cmake-modules.

Why can't we just replace the line 266 of the CreateLaunchers.cmake by:
set(USERFILE_COMMAND $<TARGET_FILE>) ??

from cmake-modules.

I assume that was a generator expression that got wiped out because it looked like an HTML tag. I think the answer is "you almost can, but not quite" because of Visual Studio (it needs per-config files generated with different names).

from cmake-modules.

any movement on this?

from cmake-modules.

My problem is that I am setting target_destination() after the create-launcher call (and can't be easily swapped due to the structure of my files).

As a work-around I did this in place of get_target_property() calls
set(USER_COMMAND "$(TargetPath)")
set(USER_WORKING_DIRECTORY "$(TargetDir)")

This makes it use VS's variable.

Would need to be fixed up in 2 or 3 places in the code.

from cmake-modules.

this PR might serve to solve this issue, #53

from cmake-modules.

Since I haven't heard anything on the PR I moved it to a new repo and also added it to hunter (cmake package handler, https://github.com/ruslo/hunter) so that it will be easier to use, https://github.com/caseymcc/CreateLaunchers

from cmake-modules.

sorry for missing this PR. While I still use and add to this repo, I don't use this particular module because I have a little more control over the software I work with and so it doesn't need a zillion arguments and environment variables 😉 , and where I have DLLs on Windows, I use https://stackoverflow.com/questions/6594796/how-do-i-make-cmake-output-into-a-bin-dir#6595001 to put them in the same dir. I'll look at and merge the PR if it's reasonable, which I'm sure it will be. I probably need to do a bit of fork management on this repo, pulling in changes out in the network, since it's by far my most popular original repo :)

from cmake-modules.

Fixed by merging #53.

from cmake-modules.