item macros not working about rune HOT 5 CLOSED

Hopefully the issue should be fixed now, please give it another shot!

from rune.

Gosh, we broke something huh. Thought we had a test for this.

I know I messed around a bit with indexing recently (this is also where all macro expansion happens), so I might've inadvertently re-ordered how items are inserted somewhere.

What happens with each AST element is that they have an opaque identifier associated with them which starts out being uninitialized. The compiler then associated data with it - in this instance item names based on a stack. This line here looks mighty suspect. Especially since we already have a usable id for the path above. The id is also only ever used for diagnostics. Or maybe we're just straight up missing ItemMeta for the root item.

Thanks for the report!

from rune.

That line seams to be the issue

[crates/rune/src/indexing/index.rs:381] compile::Error::msg(ast.span(), e) = Error {
    span: Span(
        20,
        82,
    ),
    kind: Custom {
        message: "missing last inserted id into the items stack",
    },
}

from rune.

Tried looking into it, but wasn't able to figure it out. It might be that the root ItemMeta is acutally missing, because just removing that line would yield an error on

Missing item for id Id(1)

from rune.

Got some time today to check it out, #522 should hopefully fix this. There is a bit of "identifier soup" going on right now which I'd like to refactor some time in the future, namely items have two kinds of identifiers:

• One which is associated with its allocation in the item pool (allowing for deduplicating item allocations).
• One which associated context metadata to the item, such as its visibility, which module its in, the source location it belongs to. This is what's being referenced by ast items such as ItemFn::id.

The second one is what's being associated with the opaque ast id you can see all over the place, and is the one which was missing. We just had to make sure item meta was present for it and that the Items stack which is used to build items are seeded correctly with identifiers.

from rune.