Giter VIP home page Giter VIP logo

Comments (4)

arpee avatar arpee commented on August 11, 2024

For now we want this to be 'Dot Arcade' promoting the colaboration - rather than just 'arcade'. So can the header linke be updated and the same image used (for now) as the /dotarcade page.

I am also seeing issues when the page/view aspect is very tall...

Seems like: min-height: 80vh; in the definition at line 388 is unnecessary - thought I don't know what negatives side effects
occur if it's removed. Can you check?

Thanks.

from saito-lite.

f8daniel avatar f8daniel commented on August 11, 2024

OMG, I never saw this comment until today.
Fixed the issues raised here and in the (now updated) pull request, i.e. keeping the branding more consistent and not littering the css with unnecessary commands/commented out commands.

I wasn't able to replicate any issues with the responsive layout on monster screen sizes (stretched out to 1000s of pixels either way), so should be good to merge back into the master branch and prune this fcking timeline.

For now we want this to be 'Dot Arcade' promoting the colaboration - rather than just 'arcade'. So can the header linke be updated and the same image used (for now) as the /dotarcade page.

I am also seeing issues when the page/view aspect is very tall...

Seems like: min-height: 80vh; in the definition at line 388 is unnecessary - thought I don't know what negatives side effects
occur if it's removed. Can you check?

Thanks.

from saito-lite.

arpee avatar arpee commented on August 11, 2024

Commented in the Pull request - the idea is to have the Play button in the dotarcade section on the home page trigger the same functionality as clicking the play button at /dotarcade.

from saito-lite.

arpee avatar arpee commented on August 11, 2024

All good in my testing. Triggers the popup and hits the endpoints just fine.

Thanks. Will pull.

from saito-lite.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.