Provide configurable padding for cells about fixed-data-table-2 HOT 8 CLOSED

That sound reasonable to me. Any chance you'd like to create a PR?

The class is specified here as className={cx('public/fixedDataTableCell/cellContent')}.

from fixed-data-table-2.

Padding is only added via the css. You can add

.public_fixedDataTableCell_cellContent {
  padding: 0px;
}

to your css.
Example: https://jsfiddle.net/vm0tLbbq/

from fixed-data-table-2.

I was considering submitting a PR, I just think adding a global CSS rule to your app as a way around this seems.. like the wrong way to handle this.

from fixed-data-table-2.

Yeah its not ideal, but this library absolutely requires the css file also be included.
This is what happens when you don't: https://jsfiddle.net/gpuz7dL8/

from fixed-data-table-2.

Sorry, closed this issue prematurely. If you want to put a PR that allows you to override the padding or the cellContent class, please go for it!

from fixed-data-table-2.

@alecf Would you be able to put up that PR?

from fixed-data-table-2.

I'll see what I can do.

My inclination is towards inline styles here though - i.e. moving the 8px out of the stylesheet and into FixedDataTableCellDefault.js - but that's fairly different than the current styling of the rest of the table. Any recommendations before I dive in? I just want to make sure I take the right approach before I put together a PR. How likely is it that this project will go down the Aphrodite route? (as mentioned in #51, cross-referencing this issue)

from fixed-data-table-2.

It looks like the Aphrodite approach in the cross referenced issue doesn't require any changes to FDT. Could you try that approach in your application (I intend to create and commit an example of it over the next week)?

If you have any concerns with that approach, please list them in the cross referenced thread. For now I'm going to close this issue and recommend the Aphrodite approach.

from fixed-data-table-2.