Giter VIP home page Giter VIP logo

Comments (11)

wcjordan avatar wcjordan commented on June 25, 2024 3

Kam and I are looking at adapting the code here and here to provide another scrolling handler similar to ReactWheelHandler.

The major challenge for us will be validating that the solution works on different devices and setups. Particularly the cases mentioned of plugging a touchscreen laptop into an external monitor with a mouse may be challenging.

As such, we'll try to release a beta solution sometime this week which only enables the functionality if a flag is passed in as a prop. We can then address any issues based on feedback. Thanks for reporting!

from fixed-data-table-2.

KamranAsif avatar KamranAsif commented on June 25, 2024 1

Have some basic functionality up behind a flag, as well as an example.
Would appreciate it if you could checkout the PR and test it for your use case :)

from fixed-data-table-2.

wcjordan avatar wcjordan commented on June 25, 2024 1

We've merged this issue in and will release behind a flag as part of 0.6.6 shortly. I'll close for now, but please try it out and open new issues for any instability or lack of smoothness you find.

from fixed-data-table-2.

gemedet avatar gemedet commented on June 25, 2024

Awesome, that was fast! It seems to work when I start dragging, but if I move my finger to the side it stops scrolling vertically. See my note on #7 (comment).

from fixed-data-table-2.

mahmoudfelfel avatar mahmoudfelfel commented on June 25, 2024

Thanks for working on this,
I have a similar issue, can't scroll on mobile devices, is there any updates ?

from fixed-data-table-2.

wcjordan avatar wcjordan commented on June 25, 2024

Hey @mahmoudfelfel, we have a PR up here which enables touch scrolling when a touchScrollEnabled={true} prop is passed into the table. Feel free to check it out and let us know if you find any issues with it.

Right now we're trying to resolve issues related to scroll stopping when your finger leaves the table and adding scroll deceleration so the scroll doesn't stop immediately when you remove your finger. I hope to have a more detailed update to you later this week.

from fixed-data-table-2.

mahmoudfelfel avatar mahmoudfelfel commented on June 25, 2024

@wcjordan thanks for your reply, and certainly will check the PR, test it, and give my feedback and will add comments on the PR for any issues i find.

from fixed-data-table-2.

wcjordan avatar wcjordan commented on June 25, 2024

I've added some momentum scrolling when drag is released and some tuning to make scroll smooth here: wcjordan@bffbf89

I'll integrate it with Kam's open PR when I have a chance to sync with him.

from fixed-data-table-2.

weixing2014 avatar weixing2014 commented on June 25, 2024

@wcjordan Hi, do we have any plan to support touch scrolling natively on touchscreen PCs? It seems for the time being Fixed-data-table-2 can only be scrollable in Chrome on touchscreen PCs. Thanks!

from fixed-data-table-2.

wcjordan avatar wcjordan commented on June 25, 2024

I'd be open to PRs but don't want to get to into the thick of figuring out support for browsers which haven't implemented the Touch Events API. You're welcome to experiment with the binding here. If you find something that works, feel free to extract the logic into a component and submit a PR.

from fixed-data-table-2.

weixing2014 avatar weixing2014 commented on June 25, 2024

Thanks, @wcjordan ! This is very helpful.

from fixed-data-table-2.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.