Giter VIP home page Giter VIP logo

Comments (6)

KamranAsif avatar KamranAsif commented on July 23, 2024

@wcjordan Can we close this in favor of #61 ?

from fixed-data-table-2.

wcjordan avatar wcjordan commented on July 23, 2024

I want to keep them both open as they have distinct deliverables and may have separate conversations. We can mark them both as future enhancements though (post 1.0)

from fixed-data-table-2.

leafoflegend avatar leafoflegend commented on July 23, 2024

The table I built for work I was able to get Radium to take over instead of the CSS sheet. Helped in numerous ways in easily getting to production. This was our thought exactly, how can we easily modify styles going forward. I can probably get a PR with the basic setup for this over. I haven't noticed any sort of performance loss, but I don't know how hard you guys work the table.

Also, of course too many people on our team are anti-CSS so I was having a hard time getting anything except CSS-in-JS through review.

from fixed-data-table-2.

wcjordan avatar wcjordan commented on July 23, 2024

Cool, we're definitely looking to explore new ideas here. If you could create a PR or example of how you used Radium, I think that would be very useful as we plan for future FDT versions.

from fixed-data-table-2.

apieceofbart avatar apieceofbart commented on July 23, 2024

@wcjordan In the light of #531 - wouldn't a simple solution be to expose more classNames on the elements that could overwrite the defaults?
Perhaps leave the very basic styling as default (just the positioning) and leave the rest to user ?

from fixed-data-table-2.

wcjordan avatar wcjordan commented on July 23, 2024

That would be an easy to implement solution. I think the downside is it may prove brittle and difficult to maintain if we change the tables DOM structure. One approach might be to add a way to set classnames on elements, but to name all the props with experimental so users aren't surprised if they break on upgrades.

from fixed-data-table-2.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.