Comments (6)
I am seeing this issue when running unit tests in Laravel, with my test classes extending Illuminate\Foundation\Testing\TestCase
Is it likely that the base Laravel class incorrectly handles self-references and destructors similar to #5809 (comment), and that is the cause of the segfaults I am seeing? Laravel has a ton of methods that return $this
, and none of my own tests I am adding on top of the base Laravel test classes create stubs or test self-return, so it seems like the most likely location of the issue is within the base Laravel class no?
from phpunit.
Thank you, @nielsdos, for investigating this.
I have stripped down the reproducer:
composer.json
{
"require-dev": {
"phpunit/phpunit": "^10.5"
},
"autoload": {
"classmap": [
"src/"
]
}
}
src/Example.php
<?php declare(strict_types=1);
class Example {
public function methodWithSelfReferenceReturn(): self
{
return $this;
}
public function __destruct()
{
$this->methodWithSelfReferenceReturn();
}
}
tests/ExampleTest.php
<?php declare(strict_types=1);
use PHPUnit\Framework\TestCase;
final class ExampleTest extends TestCase
{
public function testOne(): void
{
$this->createStub(Example::class);
}
}
$ php-82 ./vendor/bin/phpunit --no-configuration --do-not-cache-result tests
PHPUnit 10.5.17 by Sebastian Bergmann and contributors.
Runtime: PHP 8.2.19-dev
[1] 327489 segmentation fault (core dumped)
from phpunit.
Here is what happens in #5809 (comment):
createStub()
creates a test stub forExample
(the destructor ofExample
is not stubbed)- The destructor of
Example
is invoked - The destructor of
Example
callsmethodWithSelfReferenceReturn()
- The return value generator is called to generate a return value as no return value was configured for
methodWithSelfReferenceReturn()
on the test stub - The return value generator looks at the return type declaration for
methodWithSelfReferenceReturn()
, seesself
, resolvesself
toExample
, and creates a new test stub forExample
- And now the infinite recursion starts ...
There is no bug here, though.
The return type declaration self
"only" means that an object of the same type is to be returned. It does not mean "self reference".
If you configure methodWithSelfReferenceReturn()
on the test double to return a self reference (see below) then the return value generator does not get involved by the invocation handler and there will be no infinite recursion.
tests/ExampleTest.php
<?php declare(strict_types=1);
use PHPUnit\Framework\TestCase;
final class ExampleTest extends TestCase
{
public function testOne(): void
{
$stub = $this->createStub(Example::class);
$stub
->method('methodWithSelfReferenceReturn')
->willReturnSelf();
}
}
from phpunit.
Thanks for the great explanation!
from phpunit.
@matthewjumpsoffbuildings Please raise this question with the vendor of your framework.
from phpunit.
@matthewjumpsoffbuildings Take a look: laravel/framework#51046 (comment)
from phpunit.
Related Issues (20)
- Allow enabling process isolation on suite/test base class HOT 1
- Include deprecation/warning failures in JUnit logs
- Multiple dataProviders testCases with same key (name) are not detected HOT 1
- Allow selected deprecations to be skipped/ignored HOT 1
- Run garbage collector on AfterLastTestMethodFinished HOT 2
- Fatal with some error/exception handlers HOT 3
- Issue5592Test fails when registering an error handler in an auto_prepend_file
- assertEquals() hides contents of long strings
- Suppressed deprecations not included in baseline when ignoreSuppressionOfDeprecations is true HOT 1
- parameter names $expected, $actual don't make sense for assertLessThan() & friends
- Missing extensions in php 8.2: `ctype` and `tokenizer` HOT 2
- Various output buffer issues HOT 4
- Github template comment deprecated php.ini directive log_errors_max_len HOT 1
- PHP-Scoper 0.18.12 breaks PHAR for PHPUnit 8.5 on PHP 7.2 HOT 8
- Smarter defaults for the display of warnings, notices & co
- Mocked methods cannot be called from the original constructor of a partially mocked class HOT 4
- XML Configuration File Migrator does not remove `cacheDirectory` attribute from `<coverage>` element when migrating from PHPUnit 11.1 to PHPUnit 11.2 HOT 2
- Running tests with process isolation does not allow defining auto_prepend_file for child processes
- TestDox printer does not show previous exception
- PHP deprecations triggered within a Closure cause internal PHPUnit assert() to fail HOT 5
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from phpunit.